You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2015/03/03 01:07:58 UTC
Review Request 31646: Moving GroupKey to scheduler.base.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31646/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Bugs: AURORA-911
https://issues.apache.org/jira/browse/AURORA-911
Repository: aurora
Description
-------
Simple IDE-driven refactoring in preparation for the AURORA-911 fix.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/async/OfferManager.java 7d3713972f1df54da4c8cbaae0fca59a8a6f3d77
src/main/java/org/apache/aurora/scheduler/async/TaskGroup.java e5067e18af7c477d2927d83eacec063f3dec575a
src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 8cd6c966c9aca2e869311787fb5d5caba7439d3e
src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java d0fe3e133cbec2418f31160bf8ab8adaa45bb958
src/main/java/org/apache/aurora/scheduler/base/TaskGroupKey.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/async/OfferManagerImplTest.java 0cbc71d50612323aa4d8acc33e74b879c0a76aff
src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 4ee13c8e5d46ba863f4d9871884c7d494d07758d
src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 87bc531d2a72f21c36ddd0c1bd3b2367826cc422
Diff: https://reviews.apache.org/r/31646/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Maxim Khutornenko
Re: Review Request 31646: Moving GroupKey to scheduler.base.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31646/
-----------------------------------------------------------
(Updated March 5, 2015, 6:33 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
Bill's comments.
Bugs: AURORA-911
https://issues.apache.org/jira/browse/AURORA-911
Repository: aurora
Description
-------
Simple IDE-driven refactoring in preparation for the AURORA-911 fix.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/async/OfferManager.java 7d3713972f1df54da4c8cbaae0fca59a8a6f3d77
src/main/java/org/apache/aurora/scheduler/async/TaskGroup.java e5067e18af7c477d2927d83eacec063f3dec575a
src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 8cd6c966c9aca2e869311787fb5d5caba7439d3e
src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java d0fe3e133cbec2418f31160bf8ab8adaa45bb958
src/main/java/org/apache/aurora/scheduler/base/TaskGroupKey.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/async/OfferManagerImplTest.java 0cbc71d50612323aa4d8acc33e74b879c0a76aff
src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 4ee13c8e5d46ba863f4d9871884c7d494d07758d
src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 87bc531d2a72f21c36ddd0c1bd3b2367826cc422
Diff: https://reviews.apache.org/r/31646/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Maxim Khutornenko
Re: Review Request 31646: Moving GroupKey to scheduler.base.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On March 3, 2015, 11:54 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/base/TaskGroupKey.java, line 23
> > <https://reviews.apache.org/r/31646/diff/1/?file=882425#file882425line23>
> >
> > s/Identifying/Identifer for/
> >
> > It's not until reading this diff that i wonder why TaskGroupKey/GroupKey even exists. The best justification i have is separation of concerns from how a task is configured and how it is identified. If you agree, it would be nice to document that here.
Done.
> On March 3, 2015, 11:54 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/base/TaskGroupKey.java, line 38
> > <https://reviews.apache.org/r/31646/diff/1/?file=882425#file882425line38>
> >
> > Why the proxy method to the constructor?
To highlight the immutable final purpose of its existence.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31646/#review75093
-----------------------------------------------------------
On March 3, 2015, 12:07 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31646/
> -----------------------------------------------------------
>
> (Updated March 3, 2015, 12:07 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-911
> https://issues.apache.org/jira/browse/AURORA-911
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Simple IDE-driven refactoring in preparation for the AURORA-911 fix.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/async/OfferManager.java 7d3713972f1df54da4c8cbaae0fca59a8a6f3d77
> src/main/java/org/apache/aurora/scheduler/async/TaskGroup.java e5067e18af7c477d2927d83eacec063f3dec575a
> src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 8cd6c966c9aca2e869311787fb5d5caba7439d3e
> src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java d0fe3e133cbec2418f31160bf8ab8adaa45bb958
> src/main/java/org/apache/aurora/scheduler/base/TaskGroupKey.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/async/OfferManagerImplTest.java 0cbc71d50612323aa4d8acc33e74b879c0a76aff
> src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 4ee13c8e5d46ba863f4d9871884c7d494d07758d
> src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 87bc531d2a72f21c36ddd0c1bd3b2367826cc422
>
> Diff: https://reviews.apache.org/r/31646/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 31646: Moving GroupKey to scheduler.base.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31646/#review75093
-----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/base/TaskGroupKey.java
<https://reviews.apache.org/r/31646/#comment122028>
s/Identifying/Identifer for/
It's not until reading this diff that i wonder why TaskGroupKey/GroupKey even exists. The best justification i have is separation of concerns from how a task is configured and how it is identified. If you agree, it would be nice to document that here.
src/main/java/org/apache/aurora/scheduler/base/TaskGroupKey.java
<https://reviews.apache.org/r/31646/#comment122031>
Why the proxy method to the constructor?
- Bill Farner
On March 3, 2015, 12:07 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31646/
> -----------------------------------------------------------
>
> (Updated March 3, 2015, 12:07 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-911
> https://issues.apache.org/jira/browse/AURORA-911
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Simple IDE-driven refactoring in preparation for the AURORA-911 fix.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/async/OfferManager.java 7d3713972f1df54da4c8cbaae0fca59a8a6f3d77
> src/main/java/org/apache/aurora/scheduler/async/TaskGroup.java e5067e18af7c477d2927d83eacec063f3dec575a
> src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 8cd6c966c9aca2e869311787fb5d5caba7439d3e
> src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java d0fe3e133cbec2418f31160bf8ab8adaa45bb958
> src/main/java/org/apache/aurora/scheduler/base/TaskGroupKey.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/async/OfferManagerImplTest.java 0cbc71d50612323aa4d8acc33e74b879c0a76aff
> src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 4ee13c8e5d46ba863f4d9871884c7d494d07758d
> src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 87bc531d2a72f21c36ddd0c1bd3b2367826cc422
>
> Diff: https://reviews.apache.org/r/31646/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 31646: Moving GroupKey to scheduler.base.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31646/#review74861
-----------------------------------------------------------
Ship it!
Master (4cca6a6) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 3, 2015, 12:07 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31646/
> -----------------------------------------------------------
>
> (Updated March 3, 2015, 12:07 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-911
> https://issues.apache.org/jira/browse/AURORA-911
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Simple IDE-driven refactoring in preparation for the AURORA-911 fix.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/async/OfferManager.java 7d3713972f1df54da4c8cbaae0fca59a8a6f3d77
> src/main/java/org/apache/aurora/scheduler/async/TaskGroup.java e5067e18af7c477d2927d83eacec063f3dec575a
> src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 8cd6c966c9aca2e869311787fb5d5caba7439d3e
> src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java d0fe3e133cbec2418f31160bf8ab8adaa45bb958
> src/main/java/org/apache/aurora/scheduler/base/TaskGroupKey.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/async/OfferManagerImplTest.java 0cbc71d50612323aa4d8acc33e74b879c0a76aff
> src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 4ee13c8e5d46ba863f4d9871884c7d494d07758d
> src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 87bc531d2a72f21c36ddd0c1bd3b2367826cc422
>
> Diff: https://reviews.apache.org/r/31646/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 31646: Moving GroupKey to scheduler.base.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31646/#review75095
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On March 3, 2015, 12:07 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31646/
> -----------------------------------------------------------
>
> (Updated March 3, 2015, 12:07 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-911
> https://issues.apache.org/jira/browse/AURORA-911
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Simple IDE-driven refactoring in preparation for the AURORA-911 fix.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/async/OfferManager.java 7d3713972f1df54da4c8cbaae0fca59a8a6f3d77
> src/main/java/org/apache/aurora/scheduler/async/TaskGroup.java e5067e18af7c477d2927d83eacec063f3dec575a
> src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 8cd6c966c9aca2e869311787fb5d5caba7439d3e
> src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java d0fe3e133cbec2418f31160bf8ab8adaa45bb958
> src/main/java/org/apache/aurora/scheduler/base/TaskGroupKey.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/async/OfferManagerImplTest.java 0cbc71d50612323aa4d8acc33e74b879c0a76aff
> src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 4ee13c8e5d46ba863f4d9871884c7d494d07758d
> src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 87bc531d2a72f21c36ddd0c1bd3b2367826cc422
>
> Diff: https://reviews.apache.org/r/31646/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>