You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Vamsavardhana Reddy (JIRA)" <ji...@apache.org> on 2007/07/13 12:34:04 UTC

[jira] Created: (GERONIMO-3318) LocalAttributeManager unable to save updates to LoginModuleControlFlag attribute

LocalAttributeManager unable to save updates to LoginModuleControlFlag attribute
--------------------------------------------------------------------------------

                 Key: GERONIMO-3318
                 URL: https://issues.apache.org/jira/browse/GERONIMO-3318
             Project: Geronimo
          Issue Type: Bug
      Security Level: public (Regular issues)
          Components: core
    Affects Versions: 2.0-M7
            Reporter: Vamsavardhana Reddy
             Fix For: 2.0-M7


While editing a SecurityRealm through SecurityRealmPortlet, changes made to ControlFlag attributes are not getting saved.  An error message "Unable to store attribute type LoginModuleControlFlag" is logged. 

The problem is in GBeanOverride.getAsText() method which is trying to get LoginModuleControlFlagEditor in its own classLoader (j2ee-system) and this is resulting in ClassNotFoundException.  LoginModuleControlFlagEditor is available in j2ee-security classLoader.

Applying the overrides is happening properly as the corresponding configuration's classLoader is being used to find the property editor (in our case LoginModuleControlFlagEditor).  It may be a good idea to add a classLoader member to GBeanOverride class, initialize it to the classLoader of the configuration containing the GBean and use this classLoader wherever necessary.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (GERONIMO-3318) LocalAttributeManager unable to save updates to LoginModuleControlFlag attribute

Posted by "Vamsavardhana Reddy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vamsavardhana Reddy reassigned GERONIMO-3318:
---------------------------------------------

    Assignee: Vamsavardhana Reddy

> LocalAttributeManager unable to save updates to LoginModuleControlFlag attribute
> --------------------------------------------------------------------------------
>
>                 Key: GERONIMO-3318
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3318
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: core
>    Affects Versions: 2.0-M7
>            Reporter: Vamsavardhana Reddy
>            Assignee: Vamsavardhana Reddy
>             Fix For: 2.0-M7
>
>
> While editing a SecurityRealm through SecurityRealmPortlet, changes made to ControlFlag attributes are not getting saved.  An error message "Unable to store attribute type LoginModuleControlFlag" is logged. 
> The problem is in GBeanOverride.getAsText() method which is trying to get LoginModuleControlFlagEditor in its own classLoader (j2ee-system) and this is resulting in ClassNotFoundException.  LoginModuleControlFlagEditor is available in j2ee-security classLoader.
> Applying the overrides is happening properly as the corresponding configuration's classLoader is being used to find the property editor (in our case LoginModuleControlFlagEditor).  It may be a good idea to add a classLoader member to GBeanOverride class, initialize it to the classLoader of the configuration containing the GBean and use this classLoader wherever necessary.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (GERONIMO-3318) LocalAttributeManager unable to save updates to LoginModuleControlFlag attribute

Posted by "Vamsavardhana Reddy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vamsavardhana Reddy closed GERONIMO-3318.
-----------------------------------------

    Resolution: Fixed

Second thoughts...  instead of adding classLoader to GBeanOverride (which may break existing code), I added a classLoader parameter to GBeanOverride.getAsText() as this is the only place where the use of a proper classLoader is missing.

 o Added a ClassLoader parameter to setValue() and addGBean() methods in ManageableAttributeStore interface.
 o Added a ClassLoader parameter to GBeanOverride.getAsText() so that the configuration's classLoader could be used to find PropertyEditor
 o Changed LocalAttributeManager to account for changes to ManageableAttributeStore and GBeanOverride
 o GBeanInstance.updateManageableAttribute() now uses the configuration's classLoader with ManageableAttributeStore.setValue() call

Completed: At revision: 555993  in trunk.


> LocalAttributeManager unable to save updates to LoginModuleControlFlag attribute
> --------------------------------------------------------------------------------
>
>                 Key: GERONIMO-3318
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3318
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: core
>    Affects Versions: 2.0-M7
>            Reporter: Vamsavardhana Reddy
>            Assignee: Vamsavardhana Reddy
>             Fix For: 2.0-M7
>
>
> While editing a SecurityRealm through SecurityRealmPortlet, changes made to ControlFlag attributes are not getting saved.  An error message "Unable to store attribute type LoginModuleControlFlag" is logged. 
> The problem is in GBeanOverride.getAsText() method which is trying to get LoginModuleControlFlagEditor in its own classLoader (j2ee-system) and this is resulting in ClassNotFoundException.  LoginModuleControlFlagEditor is available in j2ee-security classLoader.
> Applying the overrides is happening properly as the corresponding configuration's classLoader is being used to find the property editor (in our case LoginModuleControlFlagEditor).  It may be a good idea to add a classLoader member to GBeanOverride class, initialize it to the classLoader of the configuration containing the GBean and use this classLoader wherever necessary.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.