[GitHub] [incubator-pagespeed-mod] jmarantz commented on pull request #2033: Use absl base64 codec in favor of our own

[GitBox <gi...@apache.org>]

jmarantz commented on pull request #2033:
URL: https://github.com/apache/incubator-pagespeed-mod/pull/2033#issuecomment-675693560


   One thing worth thinking about briefly is if this change in base64 library results in different encodings for the same data, what will be affected?
   
   I think it would not be terrible but it's worth going through a thought experiment. I suspect what will happen is during the transition there will be a variety of hash mismatches, which will result in serving resources with private,max-age=300 response headers. But things will settle out quickly.
   
   I think outline_javascript and outline_css resources will become invalid and result in 404s and broken pages, but only transiently.
   
   
   It might be worth at least checking to see whether the change causes a different encoding to occur. One way to do that would be to leave the existing tests in place.
   
   To tell the truth I'm not sure if anyone will notice these issues (the outline_* filters are terrible anyway). But it's worth just thinking about it a little, and being prepared to answer questions.
   
   I *do* think it might break some unit tests though...have you noticed?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org