You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "smjn (via GitHub)" <gi...@apache.org> on 2024/01/18 09:50:42 UTC

[PR] KAFKA-15712: Added KRaft support to MultipleListenersWithSameSecurityProtocolBaseTest [kafka]

smjn opened a new pull request, #15223:
URL: https://github.com/apache/kafka/pull/15223

   ### What
   * Added support for KRaft mode in MultipleListenersWithSameSecurityProtocolBaseTest.
   * Fixed minor issue in `ReplicaManagerTest` where incorrect non-existent method was being called from `MetadataVersion.latest` -> `MetadataVersion.latestTesting`
   
   ### Why
   * MultipleListenersWithSameSecurityProtocolBaseTest currently only supports zk mode.
   * To add support for KRaft mode, new advertised listener configs and additional mechanism to create topics was needed, which is addressed in the PR.
   
   ### Testing
   * Ran affected unit tests
   ```
   ➜  ak git:(smjn-KAFKA-15712) ./gradlew :core:test --tests kafka.server.MultipleListenersWithDefaultJaasContextTest                                                                      
   > Configure project :
   Starting build with version 3.8.0-SNAPSHOT (commit id 3c4da20e) using Gradle 8.5, Java 17 and Scala 2.13.12
   Build properties: maxParallelForks=10, maxScalacThreads=8, maxTestRetries=0
   
   > Task :core:test
   
   Gradle Test Run :core:test > Gradle Test Executor 9 > MultipleListenersWithDefaultJaasContextTest > testProduceConsume(String) > testProduceConsume(String).quorum=zk PASSED
   
   Gradle Test Run :core:test > Gradle Test Executor 9 > MultipleListenersWithDefaultJaasContextTest > testProduceConsume(String) > testProduceConsume(String).quorum=kraft PASSED
   ...
   
   BUILD SUCCESSFUL in 38s
   ```
   
   ```
   ➜  ak git:(smjn-KAFKA-15712) ./gradlew :core:test --tests kafka.server.MultipleListenersWithAdditionalJaasContextTest                                                                                 
   
   > Configure project :
   Starting build with version 3.8.0-SNAPSHOT (commit id 3c4da20e) using Gradle 8.5, Java 17 and Scala 2.13.12
   Build properties: maxParallelForks=10, maxScalacThreads=8, maxTestRetries=0
   
   > Task :core:test
   
   Gradle Test Run :core:test > Gradle Test Executor 10 > MultipleListenersWithAdditionalJaasContextTest > testProduceConsume(String) > testProduceConsume(String).quorum=zk PASSED
   
   Gradle Test Run :core:test > Gradle Test Executor 10 > MultipleListenersWithAdditionalJaasContextTest > testProduceConsume(String) > testProduceConsume(String).quorum=kraft PASSED
   ...
   
   BUILD SUCCESSFUL in 36s
   59 actionable tasks: 1 executed, 58 up-to-date
   ```
   * clean build
   ```
   ➜  ak git:(smjn-KAFKA-15712) ./gradlew clean jar                                                                                                                                                       [15:17:10]
   
   > Configure project :
   Starting build with version 3.8.0-SNAPSHOT (commit id 3c4da20e) using Gradle 8.5, Java 17 and Scala 2.13.12
   Build properties: maxParallelForks=10, maxScalacThreads=8, maxTestRetries=0
   
   > Task :core:compileScala
   [Warn] /Users/smahajan/.gradle/workers/warning:[options] bootstrap class path not set in conjunction with -source 8
   /Users/smahajan/ws/ak/core/src/main/java/kafka/log/remote/RemoteLogManager.java:235:  [removal] AccessController in java.security has been deprecated and marked for removal
   [Warn] /Users/smahajan/ws/ak/core/src/main/java/kafka/log/remote/RemoteLogManager.java:257:  [removal] AccessController in java.security has been deprecated and marked for removal
   
   > Task :core:compileTestScala
   Unexpected javac output: warning: [options] bootstrap class path not set in conjunction with -source 8
   Note: /Users/smahajan/ws/ak/core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java uses or overrides a deprecated API.
   Note: Recompile with -Xlint:deprecation for details.
   Note: Some input files use unchecked or unsafe operations.
   Note: Recompile with -Xlint:unchecked for details.
   1 warning.
   
   ...
   
   BUILD SUCCESSFUL in 1m 32s
   199 actionable tasks: 190 executed, 9 up-to-date
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-15712: Added KRaft support to MultipleListenersWithSameSecurityProtocolBaseTest [kafka]

Posted by "smjn (via GitHub)" <gi...@apache.org>.
smjn closed pull request #15223: KAFKA-15712: Added KRaft support to MultipleListenersWithSameSecurityProtocolBaseTest
URL: https://github.com/apache/kafka/pull/15223


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-15712: Added KRaft support to MultipleListenersWithSameSecurityProtocolBaseTest [kafka]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #15223:
URL: https://github.com/apache/kafka/pull/15223#issuecomment-2065686726

   This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has  merge conflicts, please update it with the latest from trunk (or appropriate release branch) <p> If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org