You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "davsclaus (via GitHub)" <gi...@apache.org> on 2026/06/06 15:26:28 UTC
[PR] CAMEL-23672: TUI - Diagram external toggle with three modes (off/edges/all) [camel]
davsclaus opened a new pull request, #23809:
URL: https://github.com/apache/camel/pull/23809
## Summary
The diagram tab's external endpoint toggle (`e` key) now cycles through three modes instead of on/off:
- **off** — no external endpoints shown
- **edges** — direct arrows between routes sharing an external endpoint, plus truly-external endpoints as dashed boxes at top/bottom bands (same as previous "on")
- **all** — shared external endpoints shown as intermediary dashed boxes between routes instead of direct arrows (e.g., `routeA → [kafka:foo] → routeB`)
## Changes
- **TopologyHelper** — new `expandExternalEdges()` method that converts external-type route-to-route edges into intermediary dashed nodes
- **DiagramTab / RoutesTab** — `e` key cycles off → edges → all → off, footer shows `[off]`/`[edges]`/`[all]`
- **DiagramSupport** — passes mode through, follows intermediary nodes for drill-down navigation
- **TopologyDiagramWidget** — recognizes `"external"` nodeType for dashed border rendering
- **TopologyMinimapWidget** — minimap now only shows routes, skipping all external nodes
## Test plan
- [ ] Press `e` to cycle through off → edges → all → off
- [ ] Verify "edges" mode shows direct arrows (same as before)
- [ ] Verify "all" mode shows intermediary dashed boxes between routes sharing external endpoints
- [ ] Verify drill-down navigation (Enter) works through intermediary external nodes
- [ ] Verify minimap only shows route boxes
_Claude Code on behalf of Claus Ibsen_
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23672: TUI - Diagram external toggle with three modes (off/edges/all) [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23809:
URL: https://github.com/apache/camel/pull/23809#issuecomment-4639494463
<!-- ci-tested-modules -->
:test_tube: **CI tested the following changed modules:**
- `components/camel-diagram`
- `dsl/camel-jbang/camel-jbang-plugin-tui`
<details><summary>All tested modules (8 modules)</summary>
- Camel :: Diagram
- Camel :: JBang :: MCP
- Camel :: JBang :: Plugin :: Route Parser
- Camel :: JBang :: Plugin :: TUI
- Camel :: JBang :: Plugin :: Validate
- Camel :: Launcher :: Container
- Camel :: YAML DSL :: Validator
- Camel :: YAML DSL :: Validator Maven Plugin
</details>
---
:gear: [View full build and test results](https://github.com/apache/camel/actions/runs/27066225475)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23672: TUI - Diagram external toggle with three modes (off/edges/all) [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23809:
URL: https://github.com/apache/camel/pull/23809#issuecomment-4639424174
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
* You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
:warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23672: TUI - Diagram external toggle with three modes (off/edges/all) [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #23809:
URL: https://github.com/apache/camel/pull/23809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org