[jira] [Comment Edited] (THRIFT-4016) testInsanity() impl does not conform to test spec in ThriftTest.thrift

["Jens Geyer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-4016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15792583#comment-15792583 ] 

Jens Geyer edited comment on THRIFT-4016 at 1/2/17 9:52 AM:
------------------------------------------------------------

Patch extracted from PR #1147 
https://github.com/apache/thrift/pull/1147

Committed, thanks [~allengeorge]!


was (Author: jensg):
Patch extracted from PR #1147 
https://github.com/apache/thrift/pull/1147

Committed, thanks George!

> testInsanity() impl does not conform to test spec in ThriftTest.thrift
> ----------------------------------------------------------------------
>
>                 Key: THRIFT-4016
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4016
>             Project: Thrift
>          Issue Type: Bug
>          Components: C# - Library, Delphi - Library
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>             Fix For: 0.11.0
>
>         Attachments: 0001-THRIFT-4016-testInsanity-impl-does-not-conform-to-te.patch, 0001-THRIFT-4016-testInsanity-impl-does-not-conform-to-te.patch
>
>
> The Delphi impl of the testInsanity() method does not conform to test spec in ThriftTest.thrift:
> {code}
>   /**
>    * So you think you've got this all worked, out eh?
>    *
>    * Creates a the returned map with these values and prints it out:
>    *   { 1 => { 2 => argument,
>    *            3 => argument,
>    *          },
>    *     2 => { 6 => <empty Insanity struct>, },
>    *   }
>    * @return map<UserId, map<Numberz,Insanity>> - a map with the above values
>    */
> {code}
> The server delivered more data and the client tested that. Running the client against (e.g.) a C++ server will incorrectly render an error about the values returned by that server being incorrect. However, the only thing wrong here is the Delphi impl of that test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)