You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jackrabbit.apache.org by "kwin (via GitHub)" <gi...@apache.org> on 2025/06/10 18:51:43 UTC
[PR] JCR-5152 Add method to check if a (local) name is valid according to JCR [jackrabbit]
kwin opened a new pull request, #248:
URL: https://github.com/apache/jackrabbit/pull/248
spec
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JCR-5152 Add method to check if a (local) name is valid according to JCR [jackrabbit]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin merged PR #248:
URL: https://github.com/apache/jackrabbit/pull/248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JCR-5152 Add method to check if a (local) name is valid according to JCR [jackrabbit]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #248:
URL: https://github.com/apache/jackrabbit/pull/248#issuecomment-2961372644
bq. JavaDoc should mention how "[" and "]" are special
How is that relevant for the newly added method? What kind of clarification do you think would be beneficial here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JCR-5152 Add method to check if a (local) name is valid according to JCR [jackrabbit]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #248:
URL: https://github.com/apache/jackrabbit/pull/248#issuecomment-2961419103
This method is more thought for write operations (i.e. creating nodes or properties). But I think that referencing the JCR spec is enough in the context of invalid JCR characters. I also don't explain why the other characters are not allowed...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JCR-5152 Add method to check if a (local) name is valid according to JCR [jackrabbit]
Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke commented on PR #248:
URL: https://github.com/apache/jackrabbit/pull/248#issuecomment-2961410295
People might be surprised that the name returned by `Item.getName()` might not be a valid local name (or am I missing something here?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JCR-5152 Add method to check if a (local) name is valid according to JCR [jackrabbit]
Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke commented on PR #248:
URL: https://github.com/apache/jackrabbit/pull/248#issuecomment-2961428599
ack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org