You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/06/02 00:05:18 UTC

[GitHub] [geode] gesterzhou commented on a change in pull request #5193: GEODE-8211: fix flaky ShutdownIntegrationTest

gesterzhou commented on a change in pull request #5193:
URL: https://github.com/apache/geode/pull/5193#discussion_r433551229



##########
File path: geode-redis/src/integrationTest/java/org/apache/geode/redis/general/ShutdownIntegrationTest.java
##########
@@ -61,7 +61,11 @@ public void shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed() {
 
     // Unfortunately Jedis' shutdown() doesn't seem to throw a JedisDataException when the command
     // returns an error.
-    jedis.shutdown();
+    try {
+      jedis.shutdown();
+    } catch (JedisConnectionException ignore) {
+      // Sometimes it throws sometimes it does not.
+    }

Review comment:
       You might need to fix line 70 too. 
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org