You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2017/08/30 17:15:34 UTC

Review Request 61994: Service repoinfo.xml needs to expose component for Ubuntu repos

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61994/
-----------------------------------------------------------

Review request for Ambari, Jayush Luniya and Sid Wagle.


Bugs: AMBARI-21856
    https://issues.apache.org/jira/browse/AMBARI-21856


Repository: ambari


Description
-------

The problem is that Ambari is using the reponame name field as the distribution when it creates the repo definition file. Since both of these repos use same distribution (which is a common Debian pattern), they collide.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java 749a95e 
  ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java cbbe92e 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/OsFamily.java b593c32 
  ambari-server/src/test/java/org/apache/ambari/server/stack/StackModuleTest.java 4698178 


Diff: https://reviews.apache.org/r/61994/diff/1/


Testing
-------

test will be fixed after solution will be approved


Thanks,

Vitalyi Brodetskyi


Re: Review Request 61994: Service repoinfo.xml needs to expose component for Ubuntu repos

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61994/
-----------------------------------------------------------

(Updated Вер. 7, 2017, 4:04 після полудня)


Review request for Ambari, Jayush Luniya and Sid Wagle.


Bugs: AMBARI-21856
    https://issues.apache.org/jira/browse/AMBARI-21856


Repository: ambari


Description
-------

The problem is that Ambari is using the reponame name field as the distribution when it creates the repo definition file. Since both of these repos use same distribution (which is a common Debian pattern), they collide.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java 3d96122 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 1a022af 
  ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java 0735e27 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryEntity.java bad8195 
  ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java 854f03f 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceOsSpecific.java 5e1d5d3 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java 17ded10 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py 058c45b 
  ambari-server/src/main/resources/stacks/HDP/2.6/repos/repoinfo.xml ff132aa 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java 3a7b19b 


Diff: https://reviews.apache.org/r/61994/diff/2/

Changes: https://reviews.apache.org/r/61994/diff/1-2/


Testing
-------

test will be fixed after solution will be approved


Thanks,

Vitalyi Brodetskyi