You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/14 14:29:36 UTC

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10859: Improvement contributing.md

codecov-commenter edited a comment on pull request #10859:
URL: https://github.com/apache/incubator-superset/pull/10859#issuecomment-692095100


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10859?src=pr&el=h1) Report
   > Merging [#10859](https://codecov.io/gh/apache/incubator-superset/pull/10859?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/136f90f87c1d2e8f681090b044fe11f11e5652c7?el=desc) will **decrease** coverage by `4.23%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10859/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10859?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10859      +/-   ##
   ==========================================
   - Coverage   65.57%   61.34%   -4.24%     
   ==========================================
     Files         809      380     -429     
     Lines       38038    24068   -13970     
     Branches     3561        0    -3561     
   ==========================================
   - Hits        24945    14765   -10180     
   + Misses      12987     9303    -3684     
   + Partials      106        0     -106     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.34% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10859?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10859/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.46% <0.00%> (ø)` | |
   | [.../src/dashboard/components/FilterTooltipWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10859/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlclRvb2x0aXBXcmFwcGVyLmpzeA==) | | |
   | [...hboard/components/filterscope/FilterScopeModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10859/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlTW9kYWwuanN4) | | |
   | [superset-frontend/src/components/AvatarIcon.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10859/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXZhdGFySWNvbi50c3g=) | | |
   | [superset-frontend/src/CRUD/CollectionTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10859/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvQ29sbGVjdGlvblRhYmxlLnRzeA==) | | |
   | [...d/src/explore/components/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10859/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uVmFsdWUuanN4) | | |
   | [...uperset-frontend/src/components/TooltipWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10859/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVG9vbHRpcFdyYXBwZXIuanN4) | | |
   | [superset-frontend/src/setup/setupPlugins.ts](https://codecov.io/gh/apache/incubator-superset/pull/10859/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2lucy50cw==) | | |
   | [...et-frontend/src/dashboard/components/CodeModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10859/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0NvZGVNb2RhbC5qc3g=) | | |
   | [.../src/explore/components/FilterDefinitionOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10859/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9GaWx0ZXJEZWZpbml0aW9uT3B0aW9uLmpzeA==) | | |
   | ... and [420 more](https://codecov.io/gh/apache/incubator-superset/pull/10859/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10859?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10859?src=pr&el=footer). Last update [136f90f...0db3f5b](https://codecov.io/gh/apache/incubator-superset/pull/10859?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org