You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@singa.apache.org by GitBox <gi...@apache.org> on 2020/06/22 09:59:26 UTC
[GitHub] [singa] joddiy opened a new pull request #750: add SpaceToDepth && DepthToSpace operators
joddiy opened a new pull request #750:
URL: https://github.com/apache/singa/pull/750
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] edited a comment on pull request #750: add SpaceToDepth && DepthToSpace operators
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #750:
URL: https://github.com/apache/singa/pull/750#issuecomment-688048146
# [Codecov](https://codecov.io/gh/apache/singa/pull/750?src=pr&el=h1) Report
> Merging [#750](https://codecov.io/gh/apache/singa/pull/750?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/178b107741081332fb51d908e87e7fa26b69779e?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/singa/pull/750?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #750 +/- ##
=======================================
Coverage 65.08% 65.08%
=======================================
Files 86 86
Lines 4786 4786
=======================================
Hits 3115 3115
Misses 1671 1671
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/750?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/750?src=pr&el=footer). Last update [178b107...c794398](https://codecov.io/gh/apache/singa/pull/750?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] dcslin commented on pull request #750: add SpaceToDepth && DepthToSpace operators
Posted by GitBox <gi...@apache.org>.
dcslin commented on pull request #750:
URL: https://github.com/apache/singa/pull/750#issuecomment-663794238
> > > @dcslin
> > > Hi, shicong, the cuda cannot support transpose with more than 4 dims, right?
> > > ```
> > > F0622 09:52:01.832056 31992 tensor_math_cuda.h:61] Check failed: shape.size() <= 5 (6 vs. 5) Dimensions (shape) beyond 5 are currently not supported
> > > ```
> >
> >
> > hi joddiy, could you help to review this PR to your branch: [joddiy#3](https://github.com/joddiy/incubator-singa/pull/3)
>
> Hi, shicong, this PR still has some problems. When we do `reshape->transpose->reshape`, each step is correct, however, once we concat these three operators together, the result is wrong. Please use this code to test:
>
> ```
> def test_reshape(self):
> X = np.array(
> [[[[0., 1., 2.], [3., 4., 5.]], [[9., 10., 11.], [12., 13., 14.]],
> [[18., 19., 20.], [21., 22., 23.]],
> [[27., 28., 29.], [30., 31., 32.]],
> [[36., 37., 38.], [39., 40., 41.]],
> [[45., 46., 47.], [48., 49., 50.]],
> [[54., 55., 56.], [57., 58., 59.]],
> [[63., 64., 65.], [66., 67., 68.]]]],
> dtype=np.float32)
> x = tensor.from_numpy(X)
> x.to_device(gpu_dev)
>
> y_t = np.reshape(X, [1, 2, 2, 2, 2, 3])
> y_t = np.transpose(y_t, [0, 3, 4, 1, 5, 2])
> y_t = np.reshape(y_t, [1, 2, 4, 6])
>
> y = singa.Reshape(x.data, [1, 2, 2, 2, 2, 3])
> y = singa.Transpose(y, [0, 3, 4, 1, 5, 2])
> y = singa.Reshape(y, [1, 2, 4, 6])
>
> np.testing.assert_array_almost_equal(tensor.to_numpy(tensor.from_raw_tensor(y)), y_t)
> ```
ok checking
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] nudles merged pull request #750: add SpaceToDepth && DepthToSpace operators
Posted by GitBox <gi...@apache.org>.
nudles merged pull request #750:
URL: https://github.com/apache/singa/pull/750
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] joddiy commented on pull request #750: add SpaceToDepth && DepthToSpace operators
Posted by GitBox <gi...@apache.org>.
joddiy commented on pull request #750:
URL: https://github.com/apache/singa/pull/750#issuecomment-691674592
ready to merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] commented on pull request #750: add SpaceToDepth && DepthToSpace operators
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #750:
URL: https://github.com/apache/singa/pull/750#issuecomment-688048146
# [Codecov](https://codecov.io/gh/apache/singa/pull/750?src=pr&el=h1) Report
> Merging [#750](https://codecov.io/gh/apache/singa/pull/750?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/178b107741081332fb51d908e87e7fa26b69779e?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/singa/pull/750?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #750 +/- ##
=======================================
Coverage 65.08% 65.08%
=======================================
Files 86 86
Lines 4786 4786
=======================================
Hits 3115 3115
Misses 1671 1671
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/750?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/750?src=pr&el=footer). Last update [178b107...c794398](https://codecov.io/gh/apache/singa/pull/750?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] joddiy commented on pull request #750: add SpaceToDepth && DepthToSpace operators
Posted by GitBox <gi...@apache.org>.
joddiy commented on pull request #750:
URL: https://github.com/apache/singa/pull/750#issuecomment-661819085
> > @dcslin
> > Hi, shicong, the cuda cannot support transpose with more than 4 dims, right?
> > ```
> > F0622 09:52:01.832056 31992 tensor_math_cuda.h:61] Check failed: shape.size() <= 5 (6 vs. 5) Dimensions (shape) beyond 5 are currently not supported
> > ```
>
> hi joddiy, could you help to review this PR to your branch: [joddiy#3](https://github.com/joddiy/incubator-singa/pull/3)
Hi, shicong, this PR still has some problems. When we do `reshape->transpose->reshape`, each step is correct, however, once we concat these three operators together, the result is wrong. Please use this code to test:
```
def test_reshape(self):
X = np.array(
[[[[0., 1., 2.], [3., 4., 5.]], [[9., 10., 11.], [12., 13., 14.]],
[[18., 19., 20.], [21., 22., 23.]],
[[27., 28., 29.], [30., 31., 32.]],
[[36., 37., 38.], [39., 40., 41.]],
[[45., 46., 47.], [48., 49., 50.]],
[[54., 55., 56.], [57., 58., 59.]],
[[63., 64., 65.], [66., 67., 68.]]]],
dtype=np.float32)
x = tensor.from_numpy(X)
x.to_device(gpu_dev)
y_t = np.reshape(X, [1, 2, 2, 2, 2, 3])
y_t = np.transpose(y_t, [0, 3, 4, 1, 5, 2])
y_t = np.reshape(y_t, [1, 2, 4, 6])
y = singa.Reshape(x.data, [1, 2, 2, 2, 2, 3])
y = singa.Transpose(y, [0, 3, 4, 1, 5, 2])
y = singa.Reshape(y, [1, 2, 4, 6])
np.testing.assert_array_almost_equal(tensor.to_numpy(tensor.from_raw_tensor(y)), y_t)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] joddiy commented on pull request #750: add SpaceToDepth && DepthToSpace operators
Posted by GitBox <gi...@apache.org>.
joddiy commented on pull request #750:
URL: https://github.com/apache/singa/pull/750#issuecomment-647416294
@dcslin
Hi, shicong, the cuda cannot support transpose with more than 4 dims, right?
```
F0622 09:52:01.832056 31992 tensor_math_cuda.h:61] Check failed: shape.size() <= 5 (6 vs. 5) Dimensions (shape) beyond 5 are currently not supported
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] dcslin commented on pull request #750: add SpaceToDepth && DepthToSpace operators
Posted by GitBox <gi...@apache.org>.
dcslin commented on pull request #750:
URL: https://github.com/apache/singa/pull/750#issuecomment-685245437
> > > > @dcslin
> > > > Hi, shicong, the cuda cannot support transpose with more than 4 dims, right?
> > > > ```
> > > > F0622 09:52:01.832056 31992 tensor_math_cuda.h:61] Check failed: shape.size() <= 5 (6 vs. 5) Dimensions (shape) beyond 5 are currently not supported
> > > > ```
> > >
> > >
> > > hi joddiy, could you help to review this PR to your branch: [joddiy#3](https://github.com/joddiy/incubator-singa/pull/3)
> >
> >
> > Hi, shicong, this PR still has some problems. When we do `reshape->transpose->reshape`, each step is correct, however, once we concat these three operators together, the result is wrong. Please use this code to test:
> > ```
> > def test_reshape(self):
> > X = np.array(
> > [[[[0., 1., 2.], [3., 4., 5.]], [[9., 10., 11.], [12., 13., 14.]],
> > [[18., 19., 20.], [21., 22., 23.]],
> > [[27., 28., 29.], [30., 31., 32.]],
> > [[36., 37., 38.], [39., 40., 41.]],
> > [[45., 46., 47.], [48., 49., 50.]],
> > [[54., 55., 56.], [57., 58., 59.]],
> > [[63., 64., 65.], [66., 67., 68.]]]],
> > dtype=np.float32)
> > x = tensor.from_numpy(X)
> > x.to_device(gpu_dev)
> >
> > y_t = np.reshape(X, [1, 2, 2, 2, 2, 3])
> > y_t = np.transpose(y_t, [0, 3, 4, 1, 5, 2])
> > y_t = np.reshape(y_t, [1, 2, 4, 6])
> >
> > y = singa.Reshape(x.data, [1, 2, 2, 2, 2, 3])
> > y = singa.Transpose(y, [0, 3, 4, 1, 5, 2])
> > y = singa.Reshape(y, [1, 2, 4, 6])
> >
> > np.testing.assert_array_almost_equal(tensor.to_numpy(tensor.from_raw_tensor(y)), y_t)
> > ```
>
> ok checking
Please refer to https://github.com/joddiy/incubator-singa/pull/3/files
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] dcslin commented on pull request #750: add SpaceToDepth && DepthToSpace operators
Posted by GitBox <gi...@apache.org>.
dcslin commented on pull request #750:
URL: https://github.com/apache/singa/pull/750#issuecomment-655237921
> @dcslin
> Hi, shicong, the cuda cannot support transpose with more than 4 dims, right?
>
> ```
> F0622 09:52:01.832056 31992 tensor_math_cuda.h:61] Check failed: shape.size() <= 5 (6 vs. 5) Dimensions (shape) beyond 5 are currently not supported
> ```
hi joddiy, could you help to review this PR to your branch: https://github.com/joddiy/incubator-singa/pull/3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org