You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/12/14 22:25:29 UTC

[GitHub] [kafka] ijuma commented on a change in pull request #9745: MINOR: fix log package `AbstractIndex.scala` file comment typo

ijuma commented on a change in pull request #9745:
URL: https://github.com/apache/kafka/pull/9745#discussion_r542870412



##########
File path: core/src/main/scala/kafka/log/AbstractIndex.scala
##########
@@ -89,7 +89,7 @@ abstract class AbstractIndex(@volatile private var _file: File, val baseOffset:
       lookup. So that, the entire warm section is really "warm".
       When doing warm-section lookup, following 3 entries are always touched: indexEntry(end), indexEntry(end-N),
       and indexEntry((end*2 -N)/2). If page size >= 4096, all the warm-section pages (3 or fewer) are touched, when we
-      touch those 3 entries. As of 2018, 4096 is the smallest page size for all the processors (x86-32, x86-64, MIPS,
+      touch those 3 entries. As of 2048, 4096 is the smallest page size for all the processors (x86-32, x86-64, MIPS,

Review comment:
       This change doesn't make sense. `2018` was meant to be the year.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org