You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Karan Mehta (JIRA)" <ji...@apache.org> on 2018/12/06 04:41:00 UTC
[jira] [Commented] (HBASE-21553) schedLock not released in
MasterProcedureScheduler
[ https://issues.apache.org/jira/browse/HBASE-21553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710977#comment-16710977 ]
Karan Mehta commented on HBASE-21553:
-------------------------------------
Good Finding [~xucang]!!
FYI [~sukumaddineni] [~swaroopa]
This is probably the root cause of stuck procedures in the cluster.
> schedLock not released in MasterProcedureScheduler
> --------------------------------------------------
>
> Key: HBASE-21553
> URL: https://issues.apache.org/jira/browse/HBASE-21553
> Project: HBase
> Issue Type: Improvement
> Reporter: Xu Cang
> Priority: Major
>
> https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/MasterProcedureScheduler.java#L749
> As shown above, we didn't unlock schedLock which can cause deadlock.
> Besides this, there are other places in this class handles schedLock.unlock in a risky manner. I'd like to move them to finally block to improve the robustness of handling locks.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)