You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@servicecomb.apache.org by "Yang Bo (JIRA)" <ji...@apache.org> on 2018/03/13 06:47:00 UTC

[jira] [Resolved] (SCB-387) Somefiles are lacking ASF header in Service Center

     [ https://issues.apache.org/jira/browse/SCB-387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yang Bo resolved SCB-387.
-------------------------
    Resolution: Fixed

> Somefiles are lacking ASF header in Service Center
> --------------------------------------------------
>
>                 Key: SCB-387
>                 URL: https://issues.apache.org/jira/browse/SCB-387
>             Project: Apache ServiceComb
>          Issue Type: Bug
>          Components: Service-Center
>            Reporter: Yang Bo
>            Assignee: Mohammad Asif Siddiqui
>            Priority: Major
>             Fix For: service-center-1.0.0-m1
>
>
> The following files does not have ASF headers
> src:
>   ./server/broker/broker.pb.go
>   ./server/broker/broker.proto
>   ./server/core/proto/services.pb.go
>   ./server/core/proto/services.proto 
>   ./server/core/swagger/v3.yaml
>   ./server/core/swagger/v4.yaml
> The pb.go files are generated by protobuf utility, perhaps we can exclude it for checking. But the .proto files should have the ASF header.
> bin:
>   ./conf/app.conf
> The apache policy states that only files that have no creativity and some simple template files for code generation can have the header omitted. Other files should all have the header included.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)