You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iceberg.apache.org by at...@apache.org on 2026/08/07 16:54:49 UTC
(iceberg-go) branch main updated: Fix stale commit-retry doc comment (#1652)
This is an automated email from the ASF dual-hosted git repository.
laskoviymishka pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg-go.git
The following commit(s) were added to refs/heads/main by this push:
new c9ad6eca9 Fix stale commit-retry doc comment (#1652)
c9ad6eca9 is described below
commit c9ad6eca995dac85c47f3fa520a4d9ed8765651d
Author: Alessandro Nori <al...@datadoghq.com>
AuthorDate: Fri Aug 7 18:54:43 2026 +0200
Fix stale commit-retry doc comment (#1652)
---
table/properties.go | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/table/properties.go b/table/properties.go
index 66314e010..3daf55974 100644
--- a/table/properties.go
+++ b/table/properties.go
@@ -111,12 +111,13 @@ const (
// CommitNumRetriesKey is the number of commit retry attempts before
// giving up on ErrCommitFailed from the catalog.
//
- // The default is 0 (no retries) until refresh-and-replay lands; a
- // retry loop that reuses the original updates/requirements will
- // fail deterministically on genuine OCC conflicts and only slow
- // down the final error. Callers that observe transient catalog
- // flakiness (dropped connections, brief 409 during leader
- // election) can raise this to recover.
+ // The default is 0 (no retries). Each retry attempt reloads the
+ // current catalog state and replays the update against it (see
+ // doCommit's refresh-and-replay loop), so raising this can resolve
+ // both transient catalog flakiness (dropped connections, brief 409
+ // during leader election) and genuine OCC conflicts from concurrent
+ // writers. It stays opt-in by default because a retry rebuilds the
+ // snapshot's manifest list and adds latency.
CommitNumRetriesKey = "commit.retry.num-retries"
CommitNumRetriesDefault = 0