You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/04/18 09:32:20 UTC
[GitHub] [zookeeper] ctubbsii commented on a change in pull request #1323:
ZOOKEEPER-3797 Conflict between fatjar and full-build Maven profiles
ctubbsii commented on a change in pull request #1323: ZOOKEEPER-3797 Conflict between fatjar and full-build Maven profiles
URL: https://github.com/apache/zookeeper/pull/1323#discussion_r410674730
##########
File path: zookeeper-it/pom.xml
##########
@@ -33,6 +33,22 @@
ZooKeeper system tests
</description>
+ <profiles>
+ <profile>
+ <id>full-build</id>
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <skipTests>true</skipTests>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
Review comment:
This can be shorter.
```suggestion
<properties>
<skipTests>true</skipTests>
</properties>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services