[GitHub] zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

[GitBox <gi...@apache.org>]

zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace
URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167252486
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/MessageId.java
 ##########
 @@ -37,6 +36,16 @@
      */
     byte[] toByteArray();
 
+    /**
+     * Get the topic name of this MessageId.
+     * This is mainly for TopicsConsumerImpl to identify a message belongs to which topic.
+     *
+     * @return the topic name
+     */
+    default String getTopicName() {
 
 Review comment:
   Yes. It is as @merlimat metioned. for MessageId, we also need `topicName` for `redeliverUnacknowledgedMessages`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services