You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2015/10/07 12:50:34 UTC
Review Request 39079: Install package command during RU should honor
excluded packages
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39079/
-----------------------------------------------------------
Review request for Ambari, Sumit Mohanty and Vitalyi Brodetskyi.
Bugs: AMBARI-13335
https://issues.apache.org/jira/browse/AMBARI-13335
Repository: ambari
Description
-------
It seems that install package custom action is not taking into account the logic in the stack to exclude packages. Therefore, it is installing hadooplzo, phoenix, even if they should be installed. This causes issue for folks using local repo which may not include these packages.
We need a design where package exclusion logic lives in a single location - perhaps stack definition itself - that is shared by Upgrade code as well as regular stack install code.
Meanwhile, we may need a hot-fix to avoid installing hadooplzo durint RU. This can be a bit hacky as its needed on 2.1.2.
Diffs
-----
ambari-server/conf/unix/ambari.properties 75e0fe1
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 6cac860
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 7030d23
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java a09edd0
Diff: https://reviews.apache.org/r/39079/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views ...................................... SUCCESS [2.817s]
[INFO] Ambari Metrics Common ............................. SUCCESS [1.477s]
[INFO] Ambari Server ..................................... SUCCESS [55:26.131s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 55:31.036s
[INFO] Finished at: Wed Oct 07 13:47:25 EEST 2015
[INFO] Final Memory: 58M/526M
[INFO] ------------------------------------------------------------------------
Thanks,
Dmitro Lisnichenko
Re: Review Request 39079: Install package command during RU should
honor excluded packages
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39079/#review101755
-----------------------------------------------------------
Ship it!
Ship It!
- Vitalyi Brodetskyi
On Жов. 7, 2015, 10:50 до полудня, Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39079/
> -----------------------------------------------------------
>
> (Updated Жов. 7, 2015, 10:50 до полудня)
>
>
> Review request for Ambari, Sumit Mohanty and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-13335
> https://issues.apache.org/jira/browse/AMBARI-13335
>
>
> Repository: ambari
>
>
> Description
> -------
>
> It seems that install package custom action is not taking into account the logic in the stack to exclude packages. Therefore, it is installing hadooplzo, phoenix, even if they should be installed. This causes issue for folks using local repo which may not include these packages.
>
> We need a design where package exclusion logic lives in a single location - perhaps stack definition itself - that is shared by Upgrade code as well as regular stack install code.
>
> Meanwhile, we may need a hot-fix to avoid installing hadooplzo durint RU. This can be a bit hacky as its needed on 2.1.2.
>
>
> Diffs
> -----
>
> ambari-server/conf/unix/ambari.properties 75e0fe1
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 6cac860
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 7030d23
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java a09edd0
>
> Diff: https://reviews.apache.org/r/39079/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [2.817s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [1.477s]
> [INFO] Ambari Server ..................................... SUCCESS [55:26.131s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 55:31.036s
> [INFO] Finished at: Wed Oct 07 13:47:25 EEST 2015
> [INFO] Final Memory: 58M/526M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>