Re: Review Request 73022: ATLAS-4032 Filter group option in the Admin Audit tab is not giving the expected output

[Mandar Ambawane <ma...@freestoneinfotech.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73022/
-----------------------------------------------------------

(Updated April 26, 2021, 7:41 a.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra.


Bugs: ATLAS-4032
    https://issues.apache.org/jira/browse/ATLAS-4032


Repository: atlas


Description
-------

In the existing code we are not including the Inner Criterias of the Filter.

Also the Condition of the Outer filter was getting applied to the Inner Filters groups.

In this patch, code refactoring is done. The code which populate the Filter Criteria is now removed.

Instead of doing it from Server end, This patch keeps the Filter Criteria in the same format which UI has sent.

Additionally this patch provides validation for the Filter Criteria 1.Attribute Name 2. Attribute Value and 3.Operator
This validation goes until the last level of the Inner Filter Criterias.


Diffs (updated)
-----

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d3 
  repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java a85e018 


Diff: https://reviews.apache.org/r/73022/diff/2/

Changes: https://reviews.apache.org/r/73022/diff/1-2/


Testing
-------

Manual testing is done for the scenarios where Filter Groups are included.

Earlier it was not giving expected search result.

With this patch we can get the expected result in the Admin Audit Search.

PreCommit: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/203/console


Thanks,

Mandar Ambawane