[GitHub] [james-project] Arsnael commented on a change in pull request #852: JAMES-3680 Document OIDC setup for IMAP/SMTP

[GitBox <gi...@apache.org>]

Arsnael commented on a change in pull request #852:
URL: https://github.com/apache/james-project/pull/852#discussion_r789297960



##########
File path: server/apps/distributed-app/docs/modules/ROOT/pages/configure/imap.adoc
##########
@@ -95,4 +107,11 @@ will use the specified value.
 | connectionLimitPerIP
 | Set the maximum simultaneous incoming connections per IP for this service
 
-|===
\ No newline at end of file
+|===
+
+=== OIDC setup
+James IMAP support XOAUTH2 authentication mechanism which allow authenticating against a OIDC providers.

Review comment:
       Opened question: I'm starting wondering if we should not review our vocabulary usage here (and our code) between OAuth2 and OIDC.
   
   OIDC is something on top of OAuth2, with the SSO concept added for example. Here with IMAP/SMTP it feels like we are only doing OAuth2 though (just getting a token... not really any SSO/SLO concepts with IMAP clients so far).
   
   I feel like we are mixing everything up together sometimes. Like in imap we have the conf under a oauth block, while in smtp it's under a oidc block, etc.
   
   IDK what do you think guys?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org