You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "chucheng92 (via GitHub)" <gi...@apache.org> on 2023/03/20 13:33:15 UTC

[GitHub] [flink] chucheng92 commented on a diff in pull request #22207: FLINK-31510. Use getMemorySize instead of getMemory.

chucheng92 commented on code in PR #22207:
URL: https://github.com/apache/flink/pull/22207#discussion_r1141590982


##########
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java:
##########
@@ -670,22 +670,22 @@ private ClusterSpecification validateClusterResources(
 
         final String note =
                 "Please check the 'yarn.scheduler.maximum-allocation-mb' and the 'yarn.nodemanager.resource.memory-mb' configuration values\n";
-        if (jobManagerMemoryMb > maximumResourceCapability.getMemory()) {
+        if (jobManagerMemoryMb > maximumResourceCapability.getMemorySize()) {

Review Comment:
   hi, i think here memory unit is MB. so we can use int, why must long ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org