You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2014/05/30 18:48:51 UTC
Review Request 22088: Views: Add
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22088/
-----------------------------------------------------------
Review request for Ambari and Nate Cole.
Bugs: AMBARI-5970
https://issues.apache.org/jira/browse/AMBARI-5970
Repository: ambari
Description
-------
Add <label> tag to <instance> so admins can set the visible label for a given instance.
This is not a required tag. If not present, label from the <view> will be used.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java 49298b0
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java 0faf411
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog161.java 2155ce6
ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java bc193a4
ambari-server/src/main/java/org/apache/ambari/server/view/configuration/InstanceConfig.java 4b0c085
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql de5a8ed
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql eec4a3a
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 330c1fb
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 2418332
ambari-server/src/test/java/org/apache/ambari/server/orm/entities/ViewInstanceEntityTest.java b8cb7f4
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog161Test.java b45e266
ambari-server/src/test/java/org/apache/ambari/server/view/configuration/InstanceConfigTest.java 4f49425
ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ViewConfigTest.java c44e40b
ambari-views/src/main/java/org/apache/ambari/view/ViewInstanceDefinition.java 58f40b0
Diff: https://reviews.apache.org/r/22088/diff/
Testing
-------
New unit tests added. All existing tests pass ...
Results :
Tests run: 1637, Failures: 0, Errors: 0, Skipped: 13
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 20:46.553s
[INFO] Finished at: Fri May 30 12:43:53 EDT 2014
[INFO] Final Memory: 36M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
Tom Beerbower
Re: Review Request 22088: Views: Add
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22088/#review44381
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On May 30, 2014, 1:12 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22088/
> -----------------------------------------------------------
>
> (Updated May 30, 2014, 1:12 p.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-5970
> https://issues.apache.org/jira/browse/AMBARI-5970
>
>
> Repository: ambari
>
>
> Description
> -------
>
>
> Add <label> tag to <instance> so admins can set the visible label for a given instance.
>
> This is not a required tag. If not present, label from the <view> will be used.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java 49298b0
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java 0faf411
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog161.java 2155ce6
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java bc193a4
> ambari-server/src/main/java/org/apache/ambari/server/view/configuration/InstanceConfig.java 4b0c085
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql de5a8ed
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql eec4a3a
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 330c1fb
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 2418332
> ambari-server/src/test/java/org/apache/ambari/server/orm/entities/ViewInstanceEntityTest.java b8cb7f4
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog161Test.java b45e266
> ambari-server/src/test/java/org/apache/ambari/server/view/configuration/InstanceConfigTest.java 4f49425
> ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ViewConfigTest.java c44e40b
> ambari-views/src/main/java/org/apache/ambari/view/ViewInstanceDefinition.java 58f40b0
>
> Diff: https://reviews.apache.org/r/22088/diff/
>
>
> Testing
> -------
>
> New unit tests added. All existing tests pass ...
>
> Results :
>
> Tests run: 1637, Failures: 0, Errors: 0, Skipped: 13
>
> ...
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:46.553s
> [INFO] Finished at: Fri May 30 12:43:53 EDT 2014
> [INFO] Final Memory: 36M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 22088: Views: Add
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22088/
-----------------------------------------------------------
(Updated May 30, 2014, 5:12 p.m.)
Review request for Ambari and Nate Cole.
Bugs: AMBARI-5970
https://issues.apache.org/jira/browse/AMBARI-5970
Repository: ambari
Description
-------
Add <label> tag to <instance> so admins can set the visible label for a given instance.
This is not a required tag. If not present, label from the <view> will be used.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java 49298b0
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java 0faf411
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog161.java 2155ce6
ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java bc193a4
ambari-server/src/main/java/org/apache/ambari/server/view/configuration/InstanceConfig.java 4b0c085
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql de5a8ed
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql eec4a3a
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 330c1fb
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 2418332
ambari-server/src/test/java/org/apache/ambari/server/orm/entities/ViewInstanceEntityTest.java b8cb7f4
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog161Test.java b45e266
ambari-server/src/test/java/org/apache/ambari/server/view/configuration/InstanceConfigTest.java 4f49425
ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ViewConfigTest.java c44e40b
ambari-views/src/main/java/org/apache/ambari/view/ViewInstanceDefinition.java 58f40b0
Diff: https://reviews.apache.org/r/22088/diff/
Testing
-------
New unit tests added. All existing tests pass ...
Results :
Tests run: 1637, Failures: 0, Errors: 0, Skipped: 13
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 20:46.553s
[INFO] Finished at: Fri May 30 12:43:53 EDT 2014
[INFO] Final Memory: 36M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
Tom Beerbower
Re: Review Request 22088: Views: Add
Posted by Tom Beerbower <tb...@hortonworks.com>.
> On May 30, 2014, 5 p.m., Nate Cole wrote:
> > ambari-server/src/test/java/org/apache/ambari/server/view/configuration/InstanceConfigTest.java, lines 60-68
> > <https://reviews.apache.org/r/22088/diff/1/?file=599854#file599854line60>
> >
> > Just one small one - can you add a definition/assertion where the label is NOT defined on the instance and instead comes from the view definition?
> >
> > I guess also related, if the label is not defined for the instance or the view, does the name get used instead?
>
> Nate Cole wrote:
> (If that is the case, is there an assertion for that somewhere too?)
Yes, good catch.
- Tom
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22088/#review44375
-----------------------------------------------------------
On May 30, 2014, 4:48 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22088/
> -----------------------------------------------------------
>
> (Updated May 30, 2014, 4:48 p.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-5970
> https://issues.apache.org/jira/browse/AMBARI-5970
>
>
> Repository: ambari
>
>
> Description
> -------
>
>
> Add <label> tag to <instance> so admins can set the visible label for a given instance.
>
> This is not a required tag. If not present, label from the <view> will be used.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java 49298b0
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java 0faf411
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog161.java 2155ce6
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java bc193a4
> ambari-server/src/main/java/org/apache/ambari/server/view/configuration/InstanceConfig.java 4b0c085
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql de5a8ed
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql eec4a3a
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 330c1fb
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 2418332
> ambari-server/src/test/java/org/apache/ambari/server/orm/entities/ViewInstanceEntityTest.java b8cb7f4
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog161Test.java b45e266
> ambari-server/src/test/java/org/apache/ambari/server/view/configuration/InstanceConfigTest.java 4f49425
> ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ViewConfigTest.java c44e40b
> ambari-views/src/main/java/org/apache/ambari/view/ViewInstanceDefinition.java 58f40b0
>
> Diff: https://reviews.apache.org/r/22088/diff/
>
>
> Testing
> -------
>
> New unit tests added. All existing tests pass ...
>
> Results :
>
> Tests run: 1637, Failures: 0, Errors: 0, Skipped: 13
>
> ...
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:46.553s
> [INFO] Finished at: Fri May 30 12:43:53 EDT 2014
> [INFO] Final Memory: 36M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 22088: Views: Add
Posted by Nate Cole <nc...@hortonworks.com>.
> On May 30, 2014, 1 p.m., Nate Cole wrote:
> > ambari-server/src/test/java/org/apache/ambari/server/view/configuration/InstanceConfigTest.java, lines 60-68
> > <https://reviews.apache.org/r/22088/diff/1/?file=599854#file599854line60>
> >
> > Just one small one - can you add a definition/assertion where the label is NOT defined on the instance and instead comes from the view definition?
> >
> > I guess also related, if the label is not defined for the instance or the view, does the name get used instead?
(If that is the case, is there an assertion for that somewhere too?)
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22088/#review44375
-----------------------------------------------------------
On May 30, 2014, 12:48 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22088/
> -----------------------------------------------------------
>
> (Updated May 30, 2014, 12:48 p.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-5970
> https://issues.apache.org/jira/browse/AMBARI-5970
>
>
> Repository: ambari
>
>
> Description
> -------
>
>
> Add <label> tag to <instance> so admins can set the visible label for a given instance.
>
> This is not a required tag. If not present, label from the <view> will be used.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java 49298b0
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java 0faf411
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog161.java 2155ce6
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java bc193a4
> ambari-server/src/main/java/org/apache/ambari/server/view/configuration/InstanceConfig.java 4b0c085
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql de5a8ed
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql eec4a3a
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 330c1fb
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 2418332
> ambari-server/src/test/java/org/apache/ambari/server/orm/entities/ViewInstanceEntityTest.java b8cb7f4
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog161Test.java b45e266
> ambari-server/src/test/java/org/apache/ambari/server/view/configuration/InstanceConfigTest.java 4f49425
> ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ViewConfigTest.java c44e40b
> ambari-views/src/main/java/org/apache/ambari/view/ViewInstanceDefinition.java 58f40b0
>
> Diff: https://reviews.apache.org/r/22088/diff/
>
>
> Testing
> -------
>
> New unit tests added. All existing tests pass ...
>
> Results :
>
> Tests run: 1637, Failures: 0, Errors: 0, Skipped: 13
>
> ...
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:46.553s
> [INFO] Finished at: Fri May 30 12:43:53 EDT 2014
> [INFO] Final Memory: 36M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 22088: Views: Add
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22088/#review44375
-----------------------------------------------------------
ambari-server/src/test/java/org/apache/ambari/server/view/configuration/InstanceConfigTest.java
<https://reviews.apache.org/r/22088/#comment78739>
Just one small one - can you add a definition/assertion where the label is NOT defined on the instance and instead comes from the view definition?
I guess also related, if the label is not defined for the instance or the view, does the name get used instead?
- Nate Cole
On May 30, 2014, 12:48 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22088/
> -----------------------------------------------------------
>
> (Updated May 30, 2014, 12:48 p.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-5970
> https://issues.apache.org/jira/browse/AMBARI-5970
>
>
> Repository: ambari
>
>
> Description
> -------
>
>
> Add <label> tag to <instance> so admins can set the visible label for a given instance.
>
> This is not a required tag. If not present, label from the <view> will be used.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java 49298b0
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java 0faf411
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog161.java 2155ce6
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java bc193a4
> ambari-server/src/main/java/org/apache/ambari/server/view/configuration/InstanceConfig.java 4b0c085
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql de5a8ed
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql eec4a3a
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 330c1fb
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 2418332
> ambari-server/src/test/java/org/apache/ambari/server/orm/entities/ViewInstanceEntityTest.java b8cb7f4
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog161Test.java b45e266
> ambari-server/src/test/java/org/apache/ambari/server/view/configuration/InstanceConfigTest.java 4f49425
> ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ViewConfigTest.java c44e40b
> ambari-views/src/main/java/org/apache/ambari/view/ViewInstanceDefinition.java 58f40b0
>
> Diff: https://reviews.apache.org/r/22088/diff/
>
>
> Testing
> -------
>
> New unit tests added. All existing tests pass ...
>
> Results :
>
> Tests run: 1637, Failures: 0, Errors: 0, Skipped: 13
>
> ...
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:46.553s
> [INFO] Finished at: Fri May 30 12:43:53 EDT 2014
> [INFO] Final Memory: 36M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Tom Beerbower
>
>