You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/24 08:03:01 UTC
[GitHub] [arrow] pitrou opened a new pull request #12703: ARROW-16016: [C++] Fix recursive ccache invocation error
pitrou opened a new pull request #12703:
URL: https://github.com/apache/arrow/pull/12703
Do not force using ccache if the user already added a compiler launcher for the same reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #12703: ARROW-16016: [C++] Fix recursive ccache invocation error
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #12703:
URL: https://github.com/apache/arrow/pull/12703#issuecomment-1077366050
That would be fine with me, I just don't know why we didn't just do that initially.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #12703: ARROW-16016: [C++] Fix recursive ccache invocation error
Posted by GitBox <gi...@apache.org>.
kou closed pull request #12703:
URL: https://github.com/apache/arrow/pull/12703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12703: ARROW-16016: [C++] Fix recursive ccache invocation error
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12703:
URL: https://github.com/apache/arrow/pull/12703#issuecomment-1078220046
Benchmark runs are scheduled for baseline = e83ef428c4429fbcf20d605ce14f2c4f240206b7 and contender = 51f837f7ccce547a8a8574dd783531fb0be792e8. 51f837f7ccce547a8a8574dd783531fb0be792e8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/863ce98a24c541ee892263a8bf0ad752...0fa9a2cd2e334a4f8325c85d1e2b3ca7/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/daed6e5e553b43f58819f6bc9c525328...13d3d857fe804404a7fe65f4d58c7c16/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/4f3ff420614d48ecb7ab00437d440da7...665d58d025674bda8252becea5cd45d8/)
[Finished :arrow_down:0.43% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/be314d4529de4d20803fb8bac5f1aa5f...ea2a5395f1b3490382bad8711fc6e48f/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12703: ARROW-16016: [C++] Fix recursive ccache invocation error
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12703:
URL: https://github.com/apache/arrow/pull/12703#issuecomment-1077355212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12703: ARROW-16016: [C++] Fix recursive ccache invocation error
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12703:
URL: https://github.com/apache/arrow/pull/12703#issuecomment-1078220046
Benchmark runs are scheduled for baseline = e83ef428c4429fbcf20d605ce14f2c4f240206b7 and contender = 51f837f7ccce547a8a8574dd783531fb0be792e8. 51f837f7ccce547a8a8574dd783531fb0be792e8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/863ce98a24c541ee892263a8bf0ad752...0fa9a2cd2e334a4f8325c85d1e2b3ca7/)
[Finished :arrow_down:0.13% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/daed6e5e553b43f58819f6bc9c525328...13d3d857fe804404a7fe65f4d58c7c16/)
[Failed :arrow_down:1.07% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/4f3ff420614d48ecb7ab00437d440da7...665d58d025674bda8252becea5cd45d8/)
[Finished :arrow_down:0.43% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/be314d4529de4d20803fb8bac5f1aa5f...ea2a5395f1b3490382bad8711fc6e48f/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #12703: ARROW-16016: [C++] Fix recursive ccache invocation error
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #12703:
URL: https://github.com/apache/arrow/pull/12703#issuecomment-1077438546
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12703: ARROW-16016: [C++] Fix recursive ccache invocation error
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12703:
URL: https://github.com/apache/arrow/pull/12703#issuecomment-1077453825
Revision: 59d9aae07a59dd9a58b20b4527317f2f15df15d4
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1789](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1789)
|Task|Status|
|----|------|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1789-github-test-build-cpp-fuzz)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1789-github-test-conda-cpp)|
|test-conda-cpp-valgrind|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1789-azure-test-conda-cpp-valgrind)|
|test-debian-10-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1789-github-test-debian-10-cpp-amd64)|
|test-debian-10-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1789-github-test-debian-10-cpp-i386)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1789-github-test-debian-11-cpp-amd64)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1789-github-test-debian-11-cpp-i386)|
|test-fedora-35-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1789-github-test-fedora-35-cpp)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1789-github-test-ubuntu-18.04-cpp)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1789-github-test-ubuntu-18.04-cpp-release)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1789-github-test-ubuntu-18.04-cpp-static)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1789-github-test-ubuntu-20.04-cpp)|
|test-ubuntu-20.04-cpp-14|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1789-github-test-ubuntu-20.04-cpp-14)|
|test-ubuntu-20.04-cpp-17|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1789-github-test-ubuntu-20.04-cpp-17)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1789-github-test-ubuntu-20.04-cpp-bundled)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1789-github-test-ubuntu-20.04-cpp-thread-sanitizer)|
|test-ubuntu-21.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1789-github-test-ubuntu-21.04-cpp)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #12703: ARROW-16016: [C++] Fix recursive ccache invocation error
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #12703:
URL: https://github.com/apache/arrow/pull/12703#issuecomment-1077342781
Not sure this is the correct fix or workaround...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #12703: ARROW-16016: [C++] Fix recursive ccache invocation error
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #12703:
URL: https://github.com/apache/arrow/pull/12703#issuecomment-1077571717
@kou Does this look ok now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #12703: ARROW-16016: [C++] Fix recursive ccache invocation error
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #12703:
URL: https://github.com/apache/arrow/pull/12703#issuecomment-1077351668
How about overwriting `CMAKE_X_COMPILER_LAUNCHER`?
```diff
diff --git a/cpp/CMakeLists.txt b/cpp/CMakeLists.txt
index ff70619440..528302de69 100644
--- a/cpp/CMakeLists.txt
+++ b/cpp/CMakeLists.txt
@@ -195,8 +195,8 @@ if(ARROW_USE_CCACHE)
find_program(CCACHE_FOUND ccache)
if(CCACHE_FOUND)
message(STATUS "Using ccache: ${CCACHE_FOUND}")
- set_property(GLOBAL PROPERTY RULE_LAUNCH_COMPILE ${CCACHE_FOUND})
- set_property(GLOBAL PROPERTY RULE_LAUNCH_LINK ${CCACHE_FOUND})
+ set(CMAKE_C_COMPILER_LAUNCHER ${CCACHE_FOUND})
+ set(CMAKE_CXX_COMPILER_LAUNCHER ${CCACHE_FOUND})
# ARROW-3985: let ccache preserve C++ comments, because some of them may be
# meaningful to the compiler
set(ENV{CCACHE_COMMENTS} "1")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12703: ARROW-16016: [C++] Fix recursive ccache invocation error
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12703:
URL: https://github.com/apache/arrow/pull/12703#issuecomment-1078220046
Benchmark runs are scheduled for baseline = e83ef428c4429fbcf20d605ce14f2c4f240206b7 and contender = 51f837f7ccce547a8a8574dd783531fb0be792e8. 51f837f7ccce547a8a8574dd783531fb0be792e8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/863ce98a24c541ee892263a8bf0ad752...0fa9a2cd2e334a4f8325c85d1e2b3ca7/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/daed6e5e553b43f58819f6bc9c525328...13d3d857fe804404a7fe65f4d58c7c16/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/4f3ff420614d48ecb7ab00437d440da7...665d58d025674bda8252becea5cd45d8/)
[Finished :arrow_down:0.43% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/be314d4529de4d20803fb8bac5f1aa5f...ea2a5395f1b3490382bad8711fc6e48f/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou edited a comment on pull request #12703: ARROW-16016: [C++] Fix recursive ccache invocation error
Posted by GitBox <gi...@apache.org>.
pitrou edited a comment on pull request #12703:
URL: https://github.com/apache/arrow/pull/12703#issuecomment-1077366050
That would be fine with me, I just don't know why we didn't just do that initially.
Edit: perhaps because that property appeared in CMake 3.4?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12703: ARROW-16016: [C++] Fix recursive ccache invocation error
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12703:
URL: https://github.com/apache/arrow/pull/12703#issuecomment-1078220046
Benchmark runs are scheduled for baseline = e83ef428c4429fbcf20d605ce14f2c4f240206b7 and contender = 51f837f7ccce547a8a8574dd783531fb0be792e8. 51f837f7ccce547a8a8574dd783531fb0be792e8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/863ce98a24c541ee892263a8bf0ad752...0fa9a2cd2e334a4f8325c85d1e2b3ca7/)
[Finished :arrow_down:0.13% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/daed6e5e553b43f58819f6bc9c525328...13d3d857fe804404a7fe65f4d58c7c16/)
[Failed :arrow_down:1.07% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/4f3ff420614d48ecb7ab00437d440da7...665d58d025674bda8252becea5cd45d8/)
[Finished :arrow_down:0.43% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/be314d4529de4d20803fb8bac5f1aa5f...ea2a5395f1b3490382bad8711fc6e48f/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org