[jira] [Commented] (ORCHESTRA-59) Orchestra does not work with JSF RI

["Leonardo Uribe (Commented) (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/ORCHESTRA-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234025#comment-13234025 ] 

Leonardo Uribe commented on ORCHESTRA-59:
-----------------------------------------

In this case, it sounds reasonable to override ExternalContext.encodeRedirectURL() and add the conversationContext query param. It is different from ORCHESTRA-60, because the encoded URL is supposed to be used in the JSF application. Anyway, I think a check to ensure the "link" is local is necessary in this place.

Suggestions are welcome.
                
> Orchestra does not work with JSF RI
> -----------------------------------
>
>                 Key: ORCHESTRA-59
>                 URL: https://issues.apache.org/jira/browse/ORCHESTRA-59
>             Project: MyFaces Orchestra
>          Issue Type: Bug
>          Components: Conversation
>    Affects Versions: 1.4
>         Environment: - Glassfish 3.3.1
> - JSF RI 2.1.3 (FCS b02)
> - MyFaces Orchestra 1.4 (JSF 2)
>            Reporter: Tomas Havelka
>
> ConversationContext request parameter is missing (it's not appended) in the url. If it's passed manually in the request url, it works.
> It's because the Mojarra 2.1.3 does not call the HttpServletResponse.encodeURL() in the ExternalContext.encodeRedirectURL() so the conversationContext is not append to the url.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira