You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/07/18 19:34:20 UTC
[GitHub] codecov-io commented on issue #5424: Avoid expensive select_star on
dashboard bootstrap data
codecov-io commented on issue #5424: Avoid expensive select_star on dashboard bootstrap data
URL: https://github.com/apache/incubator-superset/pull/5424#issuecomment-406048490
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5424?src=pr&el=h1) Report
> Merging [#5424](https://codecov.io/gh/apache/incubator-superset/pull/5424?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b0b04b319b79e299fc150837870755c2e0a51a1b?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `100%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5424/graphs/tree.svg?height=150&src=pr&token=KsB0fHcx6l&width=650)](https://codecov.io/gh/apache/incubator-superset/pull/5424?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5424 +/- ##
==========================================
- Coverage 59.1% 59.09% -0.02%
==========================================
Files 372 372
Lines 23747 23747
Branches 2758 2758
==========================================
- Hits 14036 14033 -3
- Misses 9696 9699 +3
Partials 15 15
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5424?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/5424/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.83% <ø> (ø)` | :arrow_up: |
| [superset/data/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/5424/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YS9fX2luaXRfXy5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/5424/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `78.01% <100%> (ø)` | :arrow_up: |
| [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/5424/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `53.6% <0%> (-0.48%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5424?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5424?src=pr&el=footer). Last update [b0b04b3...e521864](https://codecov.io/gh/apache/incubator-superset/pull/5424?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org