You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openjpa.apache.org by "Romain Manni-Bucau (JIRA)" <ji...@apache.org> on 2013/02/20 22:23:12 UTC

[jira] [Commented] (OPENJPA-2337) ClassFileTransformer modifies bytecode

    [ https://issues.apache.org/jira/browse/OPENJPA-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13582530#comment-13582530 ] 

Romain Manni-Bucau commented on OPENJPA-2337:
---------------------------------------------

hmm right, looked too quickly sorry.

in fact that's when there is no javaagent that the classes are updated through the stack:

at org.apache.openjpa.enhance.PCEnhancer.record(PCEnhancer.java:630)
	at org.apache.openjpa.enhance.PCEnhancer.record(PCEnhancer.java:618)
	at org.apache.openjpa.enhance.ManagedClassSubclasser.prepareUnenhancedClasses(ManagedClassSubclasser.java:164)
	at org.apache.openjpa.kernel.AbstractBrokerFactory.loadPersistentTypes(AbstractBrokerFactory.java:314)
	at org.apache.openjpa.kernel.AbstractBrokerFactory.initializeBroker(AbstractBrokerFactory.java:238)
	at org.apache.openjpa.kernel.AbstractBrokerFactory.newBroker(AbstractBrokerFactory.java:212)
	at org.apache.openjpa.kernel.DelegatingBrokerFactory.newBroker(DelegatingBrokerFactory.java:156)
	at org.apache.openjpa.persistence.EntityManagerFactoryImpl.createEntityManager(EntityManagerFactoryImpl.java:227)
	at org.apache.openjpa.persistence.EntityManagerFactoryImpl.createEntityManager(EntityManagerFactoryImpl.java:60)


think it is an issue too: you test with maven without javaagent and you get openjpa specific entities in your jar.
                
> ClassFileTransformer modifies bytecode
> --------------------------------------
>
>                 Key: OPENJPA-2337
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2337
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: Enhance
>    Affects Versions: 2.2.0, 2.2.1
>            Reporter: Romain Manni-Bucau
>            Priority: Blocker
>
> When using the JPA ClassFileTransformer from a javaagent the expected workflow is to simply convert in memory original class byte[] to an enhanced byte[].
> However since the code is shared with ant task, mvn plugin and main() enhancer it also updates the file physically.
> That's a pain for load time weaving.
> Could it be skipped when using the ClassFileTransformer?
> sounds like a bug for me, wdyt?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira