You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "helifu (Code Review)" <ge...@cloudera.org> on 2019/01/21 15:00:28 UTC

[kudu-CR] [fs]: delete the (orphaned) metadata file when repairing

Hello Kudu Jenkins, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12239

to look at the new patch set (#2).

Change subject: [fs]: delete the (orphaned) metadata file when repairing
......................................................................

[fs]: delete the (orphaned) metadata file when repairing

This patch intends to delete the (orphaned) metadata file while
the data file has gone missing and the metadata file has no live
blocks at the same time.
In the previous patch KUDU-2636, it has supported deleting the
dead container which includes data file and metadata file. So there
will be a time window between deleting these both two files, and
in extreme cases(especially in a crash or send the tserver a kill -9)
it will make a half-container. @adar has captured this type of case
under 1000 runs of dense_node-itest.

Change-Id: I2a4223d0e6385a7f7776f8fe2679a3bb16d832ab
---
M src/kudu/fs/log_block_manager-test.cc
M src/kudu/fs/log_block_manager.cc
2 files changed, 354 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/12239/2
-- 
To view, visit http://gerrit.cloudera.org:8080/12239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2a4223d0e6385a7f7776f8fe2679a3bb16d832ab
Gerrit-Change-Number: 12239
Gerrit-PatchSet: 2
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: helifu <hz...@corp.netease.com>