You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by venkat sairam <ve...@gmail.com> on 2017/11/22 17:24:41 UTC

Review Request 64035: Workflow Manager View - FS node will overwrite internal commands and replace them with blank "move" commands when reopening the node

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64035/
-----------------------------------------------------------

Review request for Ambari, Gaurav Nagar, Padma Priya N, Pallav Kulshreshtha, Prabhjyot Singh, and Rohit Choudhary.


Bugs: AMBARI-22502
    https://issues.apache.org/jira/browse/AMBARI-22502


Repository: ambari


Description
-------

Condition for importing single node have been added.


Diffs
-----

  contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js 84a789d 


Diff: https://reviews.apache.org/r/64035/diff/1/


Testing
-------

Manual testing done.


Thanks,

venkat sairam


Re: Review Request 64035: Workflow Manager View - FS node will overwrite internal commands and replace them with blank "move" commands when reopening the node

Posted by Padma Priya N <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64035/#review191782
-----------------------------------------------------------


Ship it!




Ship It!

- Padma Priya N


On Nov. 22, 2017, 5:24 p.m., venkat sairam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64035/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2017, 5:24 p.m.)
> 
> 
> Review request for Ambari, Gaurav Nagar, Padma Priya N, Pallav Kulshreshtha, Prabhjyot Singh, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-22502
>     https://issues.apache.org/jira/browse/AMBARI-22502
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Condition for importing single node have been added.
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js 84a789d 
> 
> 
> Diff: https://reviews.apache.org/r/64035/diff/1/
> 
> 
> Testing
> -------
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> venkat sairam
> 
>


Re: Review Request 64035: Workflow Manager View - FS node will overwrite internal commands and replace them with blank "move" commands when reopening the node

Posted by Prabhjyot Singh <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64035/#review191783
-----------------------------------------------------------


Ship it!




Ship It!

- Prabhjyot Singh


On Nov. 22, 2017, 10:54 p.m., venkat sairam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64035/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2017, 10:54 p.m.)
> 
> 
> Review request for Ambari, Gaurav Nagar, Padma Priya N, Pallav Kulshreshtha, Prabhjyot Singh, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-22502
>     https://issues.apache.org/jira/browse/AMBARI-22502
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Condition for importing single node have been added.
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js 84a789d 
> 
> 
> Diff: https://reviews.apache.org/r/64035/diff/1/
> 
> 
> Testing
> -------
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> venkat sairam
> 
>


Re: Review Request 64035: Workflow Manager View - FS node will overwrite internal commands and replace them with blank "move" commands when reopening the node

Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64035/#review191778
-----------------------------------------------------------


Ship it!




Ship It!

- Pallav Kulshreshtha


On Nov. 22, 2017, 5:24 p.m., venkat sairam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64035/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2017, 5:24 p.m.)
> 
> 
> Review request for Ambari, Gaurav Nagar, Padma Priya N, Pallav Kulshreshtha, Prabhjyot Singh, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-22502
>     https://issues.apache.org/jira/browse/AMBARI-22502
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Condition for importing single node have been added.
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js 84a789d 
> 
> 
> Diff: https://reviews.apache.org/r/64035/diff/1/
> 
> 
> Testing
> -------
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> venkat sairam
> 
>