You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@roller.apache.org by GitBox <gi...@apache.org> on 2021/03/19 08:21:51 UTC

[GitHub] [roller] mbien opened a new pull request #82: Added Roller 6.1 db table upgrade logic + maven dependency upgrades

mbien opened a new pull request #82:
URL: https://github.com/apache/roller/pull/82


   The table name change requires an upgrade script. Its very generic SQL but don't know on how many DBs this is going to work. I only tested it with HSQLDB.
   
   updated maven dependencies
    - guice 5 can be used again without the noaop tag on latest jdks
    - asm, spring, lucene, velocity etc
   updated webjars
    - bootstrap 3.4.1 is the last version before 4.x which comes with breaking changes
   checked JDK16 compatibility
    - required war plugin update in selenium pom
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [roller] snoopdave commented on pull request #82: Added Roller 6.1 db table upgrade logic + maven dependency upgrades

Posted by GitBox <gi...@apache.org>.
snoopdave commented on pull request #82:
URL: https://github.com/apache/roller/pull/82#issuecomment-803640577


   This LGTM except for the `TagDataServlet` warning, which is not something you changed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [roller] mbien merged pull request #82: Added Roller 6.1 db table upgrade logic + maven dependency upgrades

Posted by GitBox <gi...@apache.org>.
mbien merged pull request #82:
URL: https://github.com/apache/roller/pull/82


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [roller] mbien edited a comment on pull request #82: Added Roller 6.1 db table upgrade logic + maven dependency upgrades

Posted by GitBox <gi...@apache.org>.
mbien edited a comment on pull request #82:
URL: https://github.com/apache/roller/pull/82#issuecomment-803718244


   > This LGTM except for the `TagDataServlet` warning, which is not something you changed.
   
   thanks for reviewing Dave!
   
   regarding the unrelated TagDataServlet warning:
   see draft PR #84


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [roller] mbien commented on pull request #82: Added Roller 6.1 db table upgrade logic + maven dependency upgrades

Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #82:
URL: https://github.com/apache/roller/pull/82#issuecomment-803718244


   > This LGTM except for the `TagDataServlet` warning, which is not something you changed.
   thanks for reviewing Dave!
   
   regarding the unrelated TagDataServlet warning:
   see draft PR #84


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org