You are viewing a plain text version of this content. The canonical link for it is here.
Posted to test-dev@httpd.apache.org by Stas Bekman <st...@stason.org> on 2004/07/12 08:28:42 UTC
t_cmp() revisited
so we reverted the args to t_cmp() to comply with other Test modules
conventions, but why reverting the debug printout? I find it confusing:
# received: undef
# expected: foobar
Do the other test modules also print it reversed?
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
Re: t_cmp() revisited
Posted by Stas Bekman <st...@stason.org>.
Stas Bekman wrote:
> so we reverted the args to t_cmp() to comply with other Test modules
> conventions, but why reverting the debug printout? I find it confusing:
>
> # received: undef
> # expected: foobar
>
> Do the other test modules also print it reversed?
OK, as agreed over irc I've reversed those only for the debug printout.
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
Re: t_cmp() revisited
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
Stas Bekman wrote:
> so we reverted the args to t_cmp() to comply with other Test modules
> conventions, but why reverting the debug printout? I find it confusing:
>
> # received: undef
> # expected: foobar
>
> Do the other test modules also print it reversed?
Test::More::is() looks like this:
1..1
not ok 1 - foo should have been foo
# Failed test (foo.pl at line 5)
# got: 'foo'
# expected: 'bar'
I don't suppose it matters so long as the arguments are labled correctly.
--Geoff