[GitHub] [spark] cloud-fan commented on a change in pull request #20965: [WIP][SPARK-21870][SQL] Split aggregation code into small functions

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #20965: [WIP][SPARK-21870][SQL] Split aggregation code into small functions
URL: https://github.com/apache/spark/pull/20965#discussion_r318916769
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
 ##########
 @@ -175,7 +177,7 @@ case class HashAggregateExec(
   }
 
   // The variables used as aggregation buffer. Only used for aggregation without keys.
 
 Review comment:
   nit: let's add a comment `Each aggregate function has one more more ExprCode to update its buffer slots`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org