[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4995: Using hadoop conf and hive conf from catalog options

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on code in PR #4995:
URL: https://github.com/apache/kyuubi/pull/4995#discussion_r1241576634


##########
extensions/spark/kyuubi-spark-connector-hive/src/main/scala/org/apache/kyuubi/spark/connector/hive/HiveTableCatalog.scala:
##########
@@ -115,6 +116,19 @@ class HiveTableCatalog(sparkSession: SparkSession)
       HiveUDFExpressionBuilder)
   }
 
+  private lazy val globalTempViewManager: GlobalTempViewManager = {
+    val globalTempDB = conf.getConf(GLOBAL_TEMP_DATABASE)
+    if (externalCatalog.databaseExists(globalTempDB)) {
+      throw KyuubiHiveConnectorException(
+        s"""
+           |$globalTempDB is a system preserved database, please rename your existing database
+           |to resolve the name conflict, or set a different value for
+           |${GLOBAL_TEMP_DATABASE.key}, and launch your Spark application again.
+         """.stripMargin.split("\n").mkString(" "))

Review Comment:
   use 
   ```
   "xxx " +
   "xxx " +
   "xxx"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org