You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by pa...@apache.org on 2020/02/07 14:53:47 UTC
[wicket] branch csp updated: WICKET-6732: Do not render URL when
link is disabled or invisible
This is an automated email from the ASF dual-hosted git repository.
papegaaij pushed a commit to branch csp
in repository https://gitbox.apache.org/repos/asf/wicket.git
The following commit(s) were added to refs/heads/csp by this push:
new ba6e2c8 WICKET-6732: Do not render URL when link is disabled or invisible
ba6e2c8 is described below
commit ba6e2c8304229cdf2af3d8f71918ca0dcd4e39e3
Author: Emond Papegaaij <em...@topicus.nl>
AuthorDate: Fri Feb 7 15:53:21 2020 +0100
WICKET-6732: Do not render URL when link is disabled or invisible
---
.../main/java/org/apache/wicket/markup/html/link/ExternalLink.java | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/wicket-core/src/main/java/org/apache/wicket/markup/html/link/ExternalLink.java b/wicket-core/src/main/java/org/apache/wicket/markup/html/link/ExternalLink.java
index ce414d4..3217ee3 100644
--- a/wicket-core/src/main/java/org/apache/wicket/markup/html/link/ExternalLink.java
+++ b/wicket-core/src/main/java/org/apache/wicket/markup/html/link/ExternalLink.java
@@ -178,8 +178,13 @@ public class ExternalLink extends AbstractLink
{
super.renderHead(response);
+ if (!isEnabledInHierarchy())
+ {
+ return;
+ }
+
String url = renderUrl();
- if (isEnabledInHierarchy() && url != null)
+ if (url != null)
{
if (popupSettings != null)
{