[jira] [Commented] (MAPREDUCE-5733) (Configugration) conf.set("textinputformat.record.delimiter","myDelimiter") , is bound to typo error. Lets have it as a Static String in some class, to minimise such error. This would also help in IDE like eclipse suggesting the String.

["Bertrand Dechoux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961678#comment-13961678 ] 

Bertrand Dechoux commented on MAPREDUCE-5733:
---------------------------------------------

That's a good first step. But, actually, getter and setter should be added. The dev should not manipulate directly the key.

The same could be said about KeyValueInputFormats (getter and setter).

And last, I believe KeyValueInputFormats should also use "textinputformat.record.delimiter" but that's another topic.

> (Configugration) conf.set("textinputformat.record.delimiter","myDelimiter") , is bound to typo error. Lets have it as a Static String in some class, to minimise such error. This would also help in IDE like eclipse suggesting the String.
> --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5733
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5733
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Gelesh
>            Assignee: Abhilash S R
>            Priority: Trivial
>              Labels: patch
>         Attachments: MAPREDUCE-5733.patch
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> (Configugration) conf.set("textinputformat.record.delimiter","myDelimiter") , is bound to typo error. Lets have it as a Static String in some class, to minimise such error. This would also help in IDE like eclipse suggesting the String.



--
This message was sent by Atlassian JIRA
(v6.2#6252)