You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2016/02/19 22:26:17 UTC

svn commit: r1731299 - /jmeter/trunk/test/src/org/apache/jmeter/protocol/http/control/TestCookieManager.java

Author: pmouawad
Date: Fri Feb 19 21:26:17 2016
New Revision: 1731299

URL: http://svn.apache.org/viewvc?rev=1731299&view=rev
Log:
JUnit is wrong as per Ignore Policy contract

Modified:
    jmeter/trunk/test/src/org/apache/jmeter/protocol/http/control/TestCookieManager.java

Modified: jmeter/trunk/test/src/org/apache/jmeter/protocol/http/control/TestCookieManager.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/test/src/org/apache/jmeter/protocol/http/control/TestCookieManager.java?rev=1731299&r1=1731298&r2=1731299&view=diff
==============================================================================
--- jmeter/trunk/test/src/org/apache/jmeter/protocol/http/control/TestCookieManager.java (original)
+++ jmeter/trunk/test/src/org/apache/jmeter/protocol/http/control/TestCookieManager.java Fri Feb 19 21:26:17 2016
@@ -547,7 +547,15 @@ public class TestCookieManager extends J
             assertEquals("/sub1",man.get(1).getPath());
             assertEquals("/",man.get(2).getPath());
             String s = man.getCookieHeaderForURL(url);
+            
+            // FIXME Enable when HTTPCLIENT 4.5.2 is available
+            // With ignore policy, s is null as no match will occur, 
+            // getCookieHeaderForURL will return null 
+            //assertNull(s);
+            
+            // Remove this when HTTPCLIENT 4.5.2 is available
             assertTrue(s.length()==0);
+
             HC4CookieHandler cookieHandler = (HC4CookieHandler) man.getCookieHandler();
             List<org.apache.http.cookie.Cookie> c = 
                     cookieHandler.getCookiesForUrl(man.getCookies(), url,