You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/05/21 12:49:45 UTC
[GitHub] [kafka] nresare opened a new pull request #8707: Simplify KafkaConsumer constructor logic
nresare opened a new pull request #8707:
URL: https://github.com/apache/kafka/pull/8707
This mirrors how the KafkaProducer constructors are organised and reduce
code duplication.
More specifically this PR makes the following changes without changing any behaviour or public API:
1. Move the helper method `propsToMap()` from `KafkaProducer` to `Utils` with the other
similar helper `mkMap()` and `mkProperties()` (to make it available to KafkaConsumer).
2. Move the `ConsumerConfig` instantiation to the constructor that actually does the work.
3. Remove the `addDeserializerToConfig()` that operates on `Properties` and it's two tests, as all of those are very similar to the ones that operate on `Map<String, Object>` instances.
4. Have the `KafkaConsumer` constructors that accept `Properties` parameter convert those early to `Map<String, Object>` instances.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #8707: Simplify KafkaConsumer constructor logic
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #8707:
URL: https://github.com/apache/kafka/pull/8707#issuecomment-632182363
It seems #8605 is duplicate to this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #8707: Simplify KafkaConsumer constructor logic
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #8707:
URL: https://github.com/apache/kafka/pull/8707#issuecomment-636347175
Closing in favor of #8605.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] nresare commented on pull request #8707: Simplify KafkaConsumer constructor logic
Posted by GitBox <gi...@apache.org>.
nresare commented on pull request #8707:
URL: https://github.com/apache/kafka/pull/8707#issuecomment-632248424
@chia7712 what an interesting coincidence that our changes looks almost identical although I can assure you that they have been developed completely independently
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma closed pull request #8707: Simplify KafkaConsumer constructor logic
Posted by GitBox <gi...@apache.org>.
ijuma closed pull request #8707:
URL: https://github.com/apache/kafka/pull/8707
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org