You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/07/01 11:13:10 UTC

[GitHub] [submarine] kevin85421 commented on a change in pull request #630: SUBMARINE-886. Underscore character is invalid for experiment name

kevin85421 commented on a change in pull request #630:
URL: https://github.com/apache/submarine/pull/630#discussion_r662176730



##########
File path: submarine-workbench/workbench-web/src/app/pages/workbench/experiment/experiment-home/experiment-form/experiment-customized-form/experiment-customized-form.component.html
##########
@@ -41,6 +41,9 @@
             formControlName="experimentName"
             placeholder="mnist-example"
           />
+          <div class="alert-message" *ngIf="experiment.get('experimentName').hasError('pattern')">
+            Invalid characters exist!

Review comment:
       @ByronHsu Good idea! I have fixed it with the help of Google lol.
   <img width="461" alt="截圖 2021-07-01 下午6 34 48" src="https://user-images.githubusercontent.com/20109646/124110632-05619780-da9b-11eb-8a2c-a419b775d40c.png">
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org