You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Ben Becker <bb...@maprtech.com> on 2013/07/30 00:01:05 UTC
Review Request 13029: Implement IsNull and IsNotNull DrillFunctions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13029/
-----------------------------------------------------------
Review request for drill.
Repository: drill-git
Description
-------
Implements IsNull and IsNotNull DrillFunctions with simple tests.
Also fixes a few tangential bugs. To view in Github, see https://github.com/vrtx/incubator-drill/commits/NullOp.
Diffs
-----
sandbox/prototype/common/src/main/java/org/apache/drill/common/expression/OutputTypeDeterminer.java 0bec184
sandbox/prototype/exec/java-exec/src/main/codegen/ValueVectors/templates/NullableValueVectors.java dfec62e
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/expr/EvaluationVisitor.java 664940d
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/IsNotNull.java PRE-CREATION
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/IsNull.java PRE-CREATION
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/expr/holders/Float8Holder.java 78e7cb8
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/expr/holders/NullableFloat8Holder.java f8fa224
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/MockRecordReader.java 687b28b
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/vector/BitVector.java 0f5b7d0
sandbox/prototype/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestSimpleFunctions.java PRE-CREATION
sandbox/prototype/exec/java-exec/src/test/resources/functions/testIsNotNull.json PRE-CREATION
sandbox/prototype/exec/java-exec/src/test/resources/functions/testIsNull.json PRE-CREATION
Diff: https://reviews.apache.org/r/13029/diff/
Testing
-------
Thanks,
Ben Becker
Re: Review Request 13029: Implement IsNull and IsNotNull DrillFunctions
Posted by Timothy Chen <tn...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13029/#review24191
-----------------------------------------------------------
sandbox/prototype/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestSimpleFunctions.java
<https://reviews.apache.org/r/13029/#comment48026>
Any reason we want to keep this checked in?
- Timothy Chen
On July 29, 2013, 10:01 p.m., Ben Becker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13029/
> -----------------------------------------------------------
>
> (Updated July 29, 2013, 10:01 p.m.)
>
>
> Review request for drill.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Implements IsNull and IsNotNull DrillFunctions with simple tests.
>
> Also fixes a few tangential bugs. To view in Github, see https://github.com/vrtx/incubator-drill/commits/NullOp.
>
>
> Diffs
> -----
>
> sandbox/prototype/common/src/main/java/org/apache/drill/common/expression/OutputTypeDeterminer.java 0bec184
> sandbox/prototype/exec/java-exec/src/main/codegen/ValueVectors/templates/NullableValueVectors.java dfec62e
> sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/expr/EvaluationVisitor.java 664940d
> sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/IsNotNull.java PRE-CREATION
> sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/IsNull.java PRE-CREATION
> sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/expr/holders/Float8Holder.java 78e7cb8
> sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/expr/holders/NullableFloat8Holder.java f8fa224
> sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/MockRecordReader.java 687b28b
> sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/vector/BitVector.java 0f5b7d0
> sandbox/prototype/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestSimpleFunctions.java PRE-CREATION
> sandbox/prototype/exec/java-exec/src/test/resources/functions/testIsNotNull.json PRE-CREATION
> sandbox/prototype/exec/java-exec/src/test/resources/functions/testIsNull.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/13029/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ben Becker
>
>
Re: Review Request 13029: Implement IsNull and IsNotNull DrillFunctions
Posted by Jacques Nadeau <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13029/#review24183
-----------------------------------------------------------
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/vector/BitVector.java
<https://reviews.apache.org/r/13029/#comment48007>
This assignment is unnecessary. Valuecount shouldn't be set at allocation time. It is set once you fill up the vector and decide how many values it should hold.
sandbox/prototype/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestSimpleFunctions.java
<https://reviews.apache.org/r/13029/#comment48008>
This seems like a common situation. Any way we can abstract this so we can easily write lots of function tests without repeating ourselves?
- Jacques Nadeau
On July 29, 2013, 10:01 p.m., Ben Becker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13029/
> -----------------------------------------------------------
>
> (Updated July 29, 2013, 10:01 p.m.)
>
>
> Review request for drill.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Implements IsNull and IsNotNull DrillFunctions with simple tests.
>
> Also fixes a few tangential bugs. To view in Github, see https://github.com/vrtx/incubator-drill/commits/NullOp.
>
>
> Diffs
> -----
>
> sandbox/prototype/common/src/main/java/org/apache/drill/common/expression/OutputTypeDeterminer.java 0bec184
> sandbox/prototype/exec/java-exec/src/main/codegen/ValueVectors/templates/NullableValueVectors.java dfec62e
> sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/expr/EvaluationVisitor.java 664940d
> sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/IsNotNull.java PRE-CREATION
> sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/IsNull.java PRE-CREATION
> sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/expr/holders/Float8Holder.java 78e7cb8
> sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/expr/holders/NullableFloat8Holder.java f8fa224
> sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/MockRecordReader.java 687b28b
> sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/vector/BitVector.java 0f5b7d0
> sandbox/prototype/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestSimpleFunctions.java PRE-CREATION
> sandbox/prototype/exec/java-exec/src/test/resources/functions/testIsNotNull.json PRE-CREATION
> sandbox/prototype/exec/java-exec/src/test/resources/functions/testIsNull.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/13029/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ben Becker
>
>