[GitHub] zsxwing commented on a change in pull request #23365: [SPARK-26267][SS] Retry when detecting incorrect offsets from Kafka (2.4)

[GitBox <gi...@apache.org>]

zsxwing commented on a change in pull request #23365: [SPARK-26267][SS] Retry when detecting incorrect offsets from Kafka (2.4)
URL: https://github.com/apache/spark/pull/23365#discussion_r243664096
 
 

 ##########
 File path: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchReader.scala
 ##########
 @@ -93,7 +93,8 @@ private[kafka010] class KafkaMicroBatchReader(
     endPartitionOffsets = Option(end.orElse(null))
         .map(_.asInstanceOf[KafkaSourceOffset].partitionToOffsets)
         .getOrElse {
-          val latestPartitionOffsets = kafkaOffsetReader.fetchLatestOffsets()
+          val latestPartitionOffsets =
+            kafkaOffsetReader.fetchLatestOffsets(Some(startPartitionOffsets))
 
 Review comment:
   this is the major conflict as the API is different.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org