You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/06/25 08:44:14 UTC
[GitHub] [shardingsphere] terrymanu opened a new issue, #18583: Remove deprecated CountInstanceRulesHandler
terrymanu opened a new issue, #18583:
URL: https://github.com/apache/shardingsphere/issues/18583
CountInstanceRulesHandler breaks the pluggable design, nobody need to know all dynamic plugins.
We should split the count logic push down to each concrete rule.
The handler should be:
- [ ] SingleTableRuleResourceCountHandler
- [ ] ShardingRuleResourceCountHandler
- [ ] ReadwriteSplittingRuleResourceCountHandler
- [ ] DatabaseDiscoveryRuleResourceCountHandler
- [ ] EncryptRuleResourceCountHandler
- [ ] ShadowRuleResourceCountHandler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on issue #18583: Remove deprecated CountInstanceRulesHandler and CountInstanceRulesStatement
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #18583:
URL: https://github.com/apache/shardingsphere/issues/18583#issuecomment-1166250783
Great
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] LeeGuoPing commented on issue #18583: Remove deprecated CountInstanceRulesHandler and CountInstanceRulesStatement
Posted by GitBox <gi...@apache.org>.
LeeGuoPing commented on issue #18583:
URL: https://github.com/apache/shardingsphere/issues/18583#issuecomment-1179633576
@RaigorJiang completed all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #18583: Remove deprecated CountInstanceRulesHandler and CountInstanceRulesStatement
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #18583:
URL: https://github.com/apache/shardingsphere/issues/18583#issuecomment-1171370774
I think RQL is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] lanchengx closed issue #18583: Remove deprecated CountInstanceRulesHandler and CountInstanceRulesStatement
Posted by GitBox <gi...@apache.org>.
lanchengx closed issue #18583: Remove deprecated CountInstanceRulesHandler and CountInstanceRulesStatement
URL: https://github.com/apache/shardingsphere/issues/18583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #18583: Remove deprecated CountInstanceRulesHandler and CountInstanceRulesStatement
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #18583:
URL: https://github.com/apache/shardingsphere/issues/18583#issuecomment-1179546774
Hi @LeeGuoPing,
This issue lists some tasks, are they all completed? Or can you mark the completed parts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] LeeGuoPing commented on issue #18583: Remove deprecated CountInstanceRulesHandler and CountInstanceRulesStatement
Posted by GitBox <gi...@apache.org>.
LeeGuoPing commented on issue #18583:
URL: https://github.com/apache/shardingsphere/issues/18583#issuecomment-1170831515
@terrymanu count instance belong to RAL, the concrete rules belong to RAL or RQL? I think it belong to RQL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] LeeGuoPing commented on issue #18583: Remove deprecated CountInstanceRulesHandler and CountInstanceRulesStatement
Posted by GitBox <gi...@apache.org>.
LeeGuoPing commented on issue #18583:
URL: https://github.com/apache/shardingsphere/issues/18583#issuecomment-1166240142
May I have a try
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #18583: Remove deprecated CountInstanceRulesHandler and CountInstanceRulesStatement
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #18583:
URL: https://github.com/apache/shardingsphere/issues/18583#issuecomment-1179739128
> @RaigorJiang completed all
Well, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org