You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "pvillard31 (via GitHub)" <gi...@apache.org> on 2024/11/12 15:17:11 UTC
[PR] NIFI-13998 - Add OIDC Client Credentials Flow support to NiFi CLI [nifi]
pvillard31 opened a new pull request, #9512:
URL: https://github.com/apache/nifi/pull/9512
# Summary
[NIFI-13998](https://issues.apache.org/jira/browse/NIFI-13998) - Add OIDC Client Credentials Flow support to NiFi CLI
With [NIFI-5302](https://issues.apache.org/jira/browse/NIFI-5302) #8532, we added support for Client Credentials Flow with OIDC. This should also be made available to the NiFi CLI.
````
$ cat nifi-cli-oidc.properties
baseUrl=https://localhost:8443
truststore=...
truststoreType=PKCS12
truststorePasswd=...
oidcUrl=http://localhost:8080/realms/nifi/protocol/openid-connect/token
oidcClientId=...
oidcClientSecret=...
````
````
./bin/cli.sh nifi pg-list -p nifi-cli-oidc.properties
# Name Id Running Stopped Disabled Invalid
- ------------- ------------------------------------ ------- ------- -------- -------
1 MyPG b8bb5737-0191-1000-8462-b9822d6117f3 0 13 546 1
````
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 21
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-13998 - Add OIDC Client Credentials Flow support to NiFi CLI [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory merged PR #9512:
URL: https://github.com/apache/nifi/pull/9512
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-13998 - Add OIDC Client Credentials Flow support to NiFi CLI [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on code in PR #9512:
URL: https://github.com/apache/nifi/pull/9512#discussion_r1838304946
##########
nifi-toolkit/nifi-toolkit-cli/src/main/java/org/apache/nifi/toolkit/cli/impl/command/CommandOption.java:
##########
@@ -177,6 +177,10 @@ public enum CommandOption {
USERNAME("usr", "username", "The username for authentication when obtaining an access token", true),
PASSWORD("pwd", "password", "The password for authentication when obtaining an access token", true),
+ OIDC_URL("oidcurl", "oidcUrl", "The OIDC URL to access the token endpoint for the OAuth Client Credentials Flow", true),
Review Comment:
Regarding the property naming, it seems like it would be helpful to name this something like `oidcTokenUrl` to make it clear that this refers to the `token_endpoint`, not the OpenID Connect discovery configuration JSON. The description is clear, but making it clear in the property name would be helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org