You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "szehon-ho (via GitHub)" <gi...@apache.org> on 2026/04/07 19:08:52 UTC
[PR] [MINOR] Add PR description guidelines to AGENTS.md [spark]
szehon-ho opened a new pull request, #55242:
URL: https://github.com/apache/spark/pull/55242
### What changes were proposed in this pull request?
Require PR descriptions to use the section headings from `.github/PULL_REQUEST_TEMPLATE` in `AGENTS.md` (AI agent instructions).
### Why are the changes needed?
The previous instruction ("Follow the template") was too vague and resulted in AI-generated PRs that did not follow the template format.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
No tests needed — documentation-only change.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude (Cursor agent mode)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56378] Add PR description guidelines to AGENTS.md [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #55242:
URL: https://github.com/apache/spark/pull/55242#issuecomment-4206136820
actually I already have a fix here: https://github.com/apache/spark/pull/55139/#discussion_r3022388181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56378] Add PR description guidelines to AGENTS.md [spark]
Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho commented on PR #55242:
URL: https://github.com/apache/spark/pull/55242#issuecomment-4201596204
actually im not 100% sure , it already mentioned the template, not sure why it didnt follow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56378] Add PR description guidelines to AGENTS.md [spark]
Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho commented on PR #55242:
URL: https://github.com/apache/spark/pull/55242#issuecomment-4227218899
Fixed already in the other pr, closing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56378] Add PR description guidelines to AGENTS.md [spark]
Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho commented on PR #55242:
URL: https://github.com/apache/spark/pull/55242#issuecomment-4201589994
fyi @peter-toth @cloud-fan , i tried AGENTS.md to make the pr https://github.com/apache/spark/pull/55179
but it looked weird initially:
**Summary**
1. Converts partition-column filters to PartitionPredicates (reusing SPARK-55596 infrastructure)
2. Translates remaining data-column filters to standard V2 predicates
3. Combines them (partition predicates first) and calls table.canDeleteWhere
**Changes**
- OptimizeMetadataOnlyDeleteFromTable: Added tryDeleteWithPartitionPredicates fallback method and tryTranslateToV2 helper
- PushDownUtils: Extracted createPartitionPredicates and made flattenNestedPartitionFilters package-private for reuse; getPartitionPredicateSchema now returns None for empty partition fields
- InMemoryTableWithV2Filter: Extracted evalPredicate to companion object for reuse by test tables
- InMemoryPartitionPredicateDeleteTable (new): Test table supporting PartitionPredicates and configurable data predicate acceptance
- DataSourceV2EnhancedDeleteFilterSuite (new): 9 test cases covering first-pass accept, second-pass accept/reject, mixed partition+data filters, UDF on non-contiguous partition columns, multiple PartitionPredicates, and row-level fallback
**Test plan**
- [ ] DataSourceV2EnhancedDeleteFilterSuite — 9/9 pass
- [ ] DataSourceV2EnhancedPartitionFilterSuite — 19/19 pass (no regressions)
- [ ] GroupBasedDeleteFromTableSuite — 32/32 pass (no regressions)
- [ ] Scalastyle — 0 errors
So want to clarify to make AGENTS use the right template
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56378] Add PR description guidelines to AGENTS.md [spark]
Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho closed pull request #55242: [SPARK-56378] Add PR description guidelines to AGENTS.md
URL: https://github.com/apache/spark/pull/55242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org