You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/11/11 03:55:51 UTC
[GitHub] [pulsar-client-cpp] fregate opened a new pull request, #115: [Improve][Build] Use pulsar client as a submodule for C++ projects
fregate opened a new pull request, #115:
URL: https://github.com/apache/pulsar-client-cpp/pull/115
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.trs9rsex3xom)*.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
-->
<!-- Either this PR fixes an issue, -->
Fixes #100
### Motivation
If your project builds through CMake and you try to add pulsar-client in some directory for build with whole project (i.e. third-party submodule) you can't do this because pulsar-client CMake uses CMAKE_*_DIR for configure, and this variable always related to top-level project.
### Modifications
Change CMAKE_(SOURCES|BINARY)_DIR to PROJECT_*_DIR for library and tests
### Verifying this change
- [x] Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
Build process already covered in documentation
- [ ] `doc`
(Your PR contains doc changes)
- [x] `doc-complete`
Build process already covered in documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-cpp] BewareMyPower merged pull request #115: [Improve][Build] Use pulsar client as a submodule for C++ projects
Posted by GitBox <gi...@apache.org>.
BewareMyPower merged PR #115:
URL: https://github.com/apache/pulsar-client-cpp/pull/115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-cpp] merlimat commented on pull request #115: [Improve][Build] Use pulsar client as a submodule for C++ projects
Posted by GitBox <gi...@apache.org>.
merlimat commented on PR #115:
URL: https://github.com/apache/pulsar-client-cpp/pull/115#issuecomment-1311265295
It probably needs to be rebased on top of `main` branch. The github switch branch is messing things up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-cpp] fregate commented on pull request #115: [Improve][Build] Use pulsar client as a submodule for C++ projects
Posted by GitBox <gi...@apache.org>.
fregate commented on PR #115:
URL: https://github.com/apache/pulsar-client-cpp/pull/115#issuecomment-1311200106
change base branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-cpp] fregate commented on pull request #115: [Improve][Build] Use pulsar client as a submodule for C++ projects
Posted by GitBox <gi...@apache.org>.
fregate commented on PR #115:
URL: https://github.com/apache/pulsar-client-cpp/pull/115#issuecomment-1311597916
It looks like that
[feat] Support KeyValue Schema. #22 (https://github.com/apache/pulsar-client-cpp/pull/22)
PR broke it, because if I remove KeyValueSchemaTest.cc from tests - It works
Does CI build tests? If not - I can rebase
But it looks weird - no tests in CI )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-cpp] fregate commented on pull request #115: [Improve][Build] Use pulsar client as a submodule for C++ projects
Posted by GitBox <gi...@apache.org>.
fregate commented on PR #115:
URL: https://github.com/apache/pulsar-client-cpp/pull/115#issuecomment-1311612724
Rebased
(tests not compiles)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-cpp] fregate commented on pull request #115: [Improve][Build] Use pulsar client as a submodule for C++ projects
Posted by GitBox <gi...@apache.org>.
fregate commented on PR #115:
URL: https://github.com/apache/pulsar-client-cpp/pull/115#issuecomment-1311564751
I can't build `main` branch (tests)
```
FAILED: tests/CMakeFiles/pulsar-tests.dir/KeyValueSchemaTest.cc.o
ccache /usr/bin/c++ -DBOOST_ALLOW_DEPRECATED_HEADERS -DBOOST_ALL_NO_LIB -DBUILDING_PULSAR -DHAS_SNAPPY=0 -DHAS_ZSTD=0 -DLOG_CATEGORY_NAME=\"pulsar.\" -I/.../ws/check/pulsar/patch -I/.../ws/check/pulsar/patch/include -I/.../ws/check/pulsar/_build/patch/include -I/.../ws/check/pulsar/_build/patch/generated -I/.../ws/check/pulsar/_build/patch/generated/tests -I/.../ws/check/pulsar/patch/lib -I/.../ws/check/pulsar/_build/patch/generated/lib -g -fPIE -Wall -Wformat-security -Wvla -Werror -Wno-sign-compare -Wno-deprecated-declarations -Wno-error=cpp -msse4.2 -mpclmul -Wno-stringop-truncation -fdiagnostics-show-option -fdiagnostics-color -fvisibility=hidden -Wl,--exclude-libs,ALL -std=gnu++11 -MD -MT tests/CMakeFiles/pulsar-tests.dir/KeyValueSchemaTest.cc.o -MF tests/CMakeFiles/pulsar-tests.dir/KeyValueSchemaTest.cc.o.d -o tests/CMakeFiles/pulsar-tests.dir/KeyValueSchemaTest.cc.o -c /.../ws/check/pulsar/patch/tests/KeyValueSchemaTest.cc
In file included from /usr/include/gtest/gtest-matchers.h:44,
from /usr/include/gtest/internal/gtest-death-test-internal.h:39,
from /usr/include/gtest/gtest-death-test.h:41,
from /usr/include/gtest/gtest.h:64,
from /.../ws/check/pulsar/patch/tests/KeyValueSchemaTest.cc:19:
/usr/include/gtest/gtest-printers.h: In instantiation of ‘struct testing::internal::FindFirstPrinter<pulsar::KeyValueEncodingType, void, testing::internal::internal_stream_operator_without_lexical_name_lookup::StreamPrinter, testing::internal::ProtobufPrinter, testing::internal::ConvertibleToIntegerPrinter, testing::internal::ConvertibleToStringViewPrinter, testing::internal::RawBytesPrinter, testing::internal::FallbackPrinter>’:
/usr/include/gtest/gtest-printers.h:287:8: recursively required from ‘struct testing::internal::FindFirstPrinter<pulsar::KeyValueEncodingType, void, testing::internal::FunctionPointerPrinter, testing::internal::PointerPrinter, testing::internal::internal_stream_operator_without_lexical_name_lookup::StreamPrinter, testing::internal::ProtobufPrinter, testing::internal::ConvertibleToIntegerPrinter, testing::internal::ConvertibleToStringViewPrinter, testing::internal::RawBytesPrinter, testing::internal::FallbackPrinter>’
/usr/include/gtest/gtest-printers.h:287:8: required from ‘struct testing::internal::FindFirstPrinter<pulsar::KeyValueEncodingType, void, testing::internal::ContainerPrinter, testing::internal::FunctionPointerPrinter, testing::internal::PointerPrinter, testing::internal::internal_stream_operator_without_lexical_name_lookup::StreamPrinter, testing::internal::ProtobufPrinter, testing::internal::ConvertibleToIntegerPrinter, testing::internal::ConvertibleToStringViewPrinter, testing::internal::RawBytesPrinter, testing::internal::FallbackPrinter>’
/usr/include/gtest/gtest-printers.h:307:9: required from ‘void testing::internal::PrintWithFallback(const T&, std::ostream*) [with T = pulsar::KeyValueEncodingType; std::ostream = std::basic_ostream<char>]’
/usr/include/gtest/gtest-printers.h:441:30: required from ‘void testing::internal::PrintTo(const T&, std::ostream*) [with T = pulsar::KeyValueEncodingType; std::ostream = std::basic_ostream<char>]’
/usr/include/gtest/gtest-printers.h:691:12: required from ‘static void testing::internal::UniversalPrinter<T>::Print(const T&, std::ostream*) [with T = pulsar::KeyValueEncodingType; std::ostream = std::basic_ostream<char>]’
/usr/include/gtest/gtest-printers.h:980:30: required from ‘void testing::internal::UniversalPrint(const T&, std::ostream*) [with T = pulsar::KeyValueEncodingType; std::ostream = std::basic_ostream<char>]’
/usr/include/gtest/gtest-printers.h:865:19: required from ‘static void testing::internal::UniversalTersePrinter<T>::Print(const T&, std::ostream*) [with T = pulsar::KeyValueEncodingType; std::ostream = std::basic_ostream<char>]’
/usr/include/gtest/gtest-printers.h:1018:44: required from ‘std::string testing::PrintToString(const T&) [with T = pulsar::KeyValueEncodingType; std::string = std::__cxx11::basic_string<char>]’
/usr/include/gtest/internal/gtest-param-util.h:593:28: required from ‘void testing::internal::ParameterizedTestSuiteInfo<TestSuite>::RegisterTests() [with TestSuite = KeyValueSchemaTest]’
/usr/include/gtest/internal/gtest-param-util.h:543:8: required from here
/usr/include/gtest/gtest-printers.h:291:36: error: no matching function for call to ‘testing::internal::internal_stream_operator_without_lexical_name_lookup::StreamPrinter::PrintValue(const pulsar::KeyValueEncodingType&, std::nullptr_t)’
291 | T, decltype(Printer::PrintValue(std::declval<const T&>(), nullptr)),
| ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/gtest/gtest-printers.h:212:15: note: candidate: ‘template<class T, class, class> static void testing::internal::internal_stream_operator_without_lexical_name_lookup::StreamPrinter::PrintValue(const T&, std::ostream*)’
212 | static void PrintValue(const T& value, ::std::ostream* os) {
| ^~~~~~~~~~
/usr/include/gtest/gtest-printers.h:212:15: note: template argument deduction/substitution failed:
/usr/include/gtest/gtest-printers.h:211:33: error: no match for ‘operator<<’ (operand types are ‘std::basic_ostream<char>’ and ‘const pulsar::KeyValueEncodingType’)
210 | typename = decltype(std::declval<std::ostream&>()
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
211 | << std::declval<const T&>())>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
```
Release tag build correctly
configure command: `cmake -G Ninja -DCMAKE_BUILD_TYPE=Debug -DCMAKE_CXX_COMPILER_LAUNCHER=ccache`
build command: `cmake --build --target pulsar-tests -j 15`
CMake output:
```
-- The C compiler identification is GNU 11.3.0
-- The CXX compiler identification is GNU 11.3.0
-- LINK_STATIC: OFF
-- Using CCache
-- ARCHITECTURE: x86_64
-- BUILD_DYNAMIC_LIB: ON
-- BUILD_STATIC_LIB: ON
-- BUILD_TESTS: ON
-- BUILD_WIRESHARK: OFF
-- BUILD_PERF_TOOLS: OFF
-- USE_LOG4CXX: OFF
-- CMAKE_BUILD_TYPE: Debug
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org