[GitHub] spark issue #18022: [SPARK-20790] [MLlib] Correctly handle negative values f...

[MLnick <gi...@git.apache.org>]

Github user MLnick commented on the issue:

    https://github.com/apache/spark/pull/18022
  
    Yeah you can just open a small follow up PR
    On Fri, 2 Jun 2017 at 15:10, davideis <no...@github.com> wrote:
    
    > *@davideis* commented on this pull request.
    > ------------------------------
    >
    > In mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala
    > <https://github.com/apache/spark/pull/18022#discussion_r119852009>:
    >
    > > @@ -455,6 +487,22 @@ class ALSSuite
    >        targetRMSE = 0.3)
    >    }
    >
    > +  test("implicit feedback regression") {
    > +    val trainingWithNeg = sc.parallelize(Array(Rating(0, 0, 1), Rating(1, 1, 1), Rating(0, 1, -3)))
    > +    val trainingWithZero = sc.parallelize(Array(Rating(0, 0, 1), Rating(1, 1, 1), Rating(0, 1, 0)))
    > +    val modelWithNeg =
    > +      trainALS(trainingWithNeg, rank = 1, maxIter = 5, regParam = 0.01, implicitPrefs = true)
    > +    val modelWithZero =
    > +      trainALS(trainingWithZero, rank = 1, maxIter = 5, regParam = 0.01, implicitPrefs = true)
    > +    val userFactorsNeg = modelWithNeg.userFactors
    > +    val itemFactorsNeg = modelWithNeg.itemFactors
    > +    val userFactorsZero = modelWithZero.userFactors
    > +    val itemFactorsZero = modelWithZero.itemFactors
    > +    userFactorsNeg.collect().foreach(arr => logInfo(s"implicit test " + arr.mkString(" ")))
    >
    > Good point, I meant to remove, shall I open another pr?
    >
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/spark/pull/18022#discussion_r119852009>, or mute
    > the thread
    > <https://github.com/notifications/unsubscribe-auth/AA_SBxnsNsrJoMbMWP1I8Fvr9GAPHNxcks5sAAnGgaJpZM4NecIX>
    > .
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org