You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Vrushali C (JIRA)" <ji...@apache.org> on 2018/03/28 04:43:00 UTC

[jira] [Comment Edited] (YARN-8073) TimelineClientImpl doesn't honor yarn.timeline-service.versions configuration

    [ https://issues.apache.org/jira/browse/YARN-8073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416814#comment-16416814 ] 

Vrushali C edited comment on YARN-8073 at 3/28/18 4:42 AM:
-----------------------------------------------------------

Hi Rohith

Thanks for the patch. It looks like in YARN-6736, there are functions to check if  V1 (YarnConfiguration#timelineServiceV1Enabled) and V2  (YarnConfiguration#timelineServiceV2Enabled) are enabled but not for V 1.5.  

So I agree about adding timelineServiceV1_5Enabled. 

I am a bit unsure about the changes in TimelineClientImpl. It looks correct but are they required or would the earlier code be ok too? 





was (Author: vrushalic):
Hi Rohith

Thanks for the patch. It looks like in YARN-6736, there are functions to check if  V1 and V2  are enabled but not for V 1.5. YarnConfiguration#timelineServiceV1Enabled and 

So I agree about adding timelineServiceV1_5Enabled. 

I am a bit unsure about the changes in TimelineClientImpl. It looks correct but are they required or would the earlier code be ok too? 




> TimelineClientImpl doesn't honor yarn.timeline-service.versions configuration
> -----------------------------------------------------------------------------
>
>                 Key: YARN-8073
>                 URL: https://issues.apache.org/jira/browse/YARN-8073
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>            Priority: Major
>         Attachments: YARN-8073.01.patch
>
>
> Post YARN-6736, RM support writing into ats v1 and v2 by new configuration setting _yarn.timeline-service.versions_. 
>  Couple of issues observed in deployment are
>  # TimelineClientImpl doesn't honor newly added configuration rather it still get version number from _yarn.timeline-service.version_. This causes not writing into v1.5 API's even though _yarn.timeline-service.versions has 1.5 value._ 
>  # Similar line from 1st point, TimelineUtils#timelineServiceV1_5Enabled doesn't honor timeline-service.versions.
>  # JobHistoryEventHandler#serviceInit(), line no 271 check for version number rather than calling YarnConfiguration#timelineServiceV2Enabled
> cc :/ [~agresch]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org