Re: [PR] Fixed the hardcoded default namespace value for GCP Data Fusion links. [airflow]

["Taragolis (via GitHub)" <gi...@apache.org>]

Taragolis commented on code in PR #35379:
URL: https://github.com/apache/airflow/pull/35379#discussion_r1380708356


##########
airflow/providers/google/cloud/links/datafusion.py:
##########
@@ -30,8 +30,8 @@
 
 BASE_LINK = "https://console.cloud.google.com/data-fusion"
 DATAFUSION_INSTANCE_LINK = BASE_LINK + "/locations/{region}/instances/{instance_name}?project={project_id}"
-DATAFUSION_PIPELINES_LINK = "{uri}/cdap/ns/default/pipelines"
-DATAFUSION_PIPELINE_LINK = "{uri}/pipelines/ns/default/view/{pipeline_name}"
+DATAFUSION_PIPELINES_LINK = "{uri}/cdap/ns/{namespace}/pipelines"
+DATAFUSION_PIPELINE_LINK = "{uri}/pipelines/ns/{namespace}/view/{pipeline_name}"

Review Comment:
   What is happen with already created links? Asked because current information which are stored into the XCom doesn't contain information about namespace



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org