[GitHub] thrift issue #1314: THRIFT-4263: Fix use after free bug for thrown exception...

[norrs <gi...@git.apache.org>]

Github user norrs commented on the issue:

    https://github.com/apache/thrift/pull/1314
  
    Side story:
    
    Ok, I was hoping travis would run the cross compile tests with php7, but sadly it doesn't. As I was hoping the build would fail with the test case before submitting, as this is what we've used for testing it under valgrind.
    
    
    Currently cross compile builds runs with ubuntu 1404 trusty. For thrift as a project you might consider trying to maybe bump this dependency, as maintenance updates for 1404 is more or less going away this year according to https://www.ubuntu.com/info/release-end-of-life . 
    
    You will also need min 1604 for php7 packages. Sadly the test suite really doesn't run with newer versions, at least python tests seems to start failing. Another problem is the system tests with (cross-compile) doesn't use cmake yet, which seems to have an idea about being able to select which libraries you want to include in the build. 
    
    Also note that PHP5 != PHP7 , and you probably want to focus new development towards PHP7. http://php.net/supported-versions.php . 
    
    Ideally CI should maybe build with latest distros where developers hang and live :-)
    
    Anyhow, me and @zhaakhi rolled out this in production for our systems and haven't noticed any segfaults since we deployed it 24 hours ago. But we did revert https://github.com/apache/thrift/pull/1215 in our fork that we have deployed, since we noticed memory leaks from it. Unsure if it was due to me  not ensuring newer thrift compiler under testing, but didn't want to risk it. I've also left a note about it in https://issues.apache.org/jira/browse/THRIFT-4126 . 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---