You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/06 01:20:10 UTC
[PR] test: expand native metric catalog service coverage [rocketmq-dashboard]
yyqdbngt opened a new pull request, #3909:
URL: https://github.com/apache/rocketmq-dashboard/pull/3909
### Motivation
The native metric catalog service tests covered Apache/Aliyun catalog filtering and key normalization, but the blank-id guard, unknown-instance 404, Tencent vendor path, and no-metric validation no-op were untested. This PR grows the suite from 2 to 6 cases.
### Changes
- `list` rejects null/blank instance ids with a 400 `instanceId is required` message.
- An unknown instance resolves to a 404 `Instance not found` error.
- Tencent business/cluster instances share the cloud catalogs with Aliyun.
- `validate` is a silent no-op for a null rule or a rule without a metric.
### Verification
- `mvn -B test -Dtest=NativeAlertMetricCatalogServiceTest`: 6/6 passed, BUILD SUCCESS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: expand native metric catalog service coverage [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3909: test: expand native metric catalog service coverage
URL: https://github.com/apache/rocketmq-dashboard/pull/3909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org