You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Eric Bresie <eb...@gmail.com> on 2021/10/26 17:48:42 UTC
[Compress] Pack200Exceptions on Old packed files
While trying to unpack an older generated pack file, it was noted that Pack200Exceptions were getting raised due to the Major/Minor Version in used which seems to be I this area.
https://github.com/apache/commons-compress/blob/master/src/main/java/org/apache/commons/compress/harmony/unpack200/SegmentHeader.java#L131-L155
Is there an work to support newer versions?
Eric Bresie
Ebresie@gmail.com
Re: [Compress] Pack200Exceptions on Old packed files
Posted by Gary Gregory <ga...@gmail.com>.
Our pack200 support was picked up and integrated from the now defunct
Apache Harmony; beyond that, we all have to learn it as it lays in our
repo. I'm afraid I do not have much to offer beyond moral support and PR
reviews; -) I'll learn and review as you go...
Gary
On Fri, Nov 5, 2021, 19:04 Eric Bresie <eb...@gmail.com> wrote:
> Where in the current implementation might one look for these sorts of
> things?
>
> In the quoted code seems to focus on the SegmentHeader related details
> would something around this be needed?
> I see some of the major/minor may be based on read code and relate to the
> Codec in use.
>
> While looking for SegmentHeader code read code which keys on different
> possible codec. For newer iterations has the codec changed would some new
> codec need to be added? Since this was an older package I wouldn’t have
> thought so.
>
> I find the following which maybe would be helpful but not sure yet.
>
> https://docs.oracle.com/javase/7/docs/technotes/guides/pack200/pack-spec.html
>
>
> Eric Bresie
> ebresie@gmail.com
>
>
> On Sun, Oct 31, 2021 at 4:44 PM Gary Gregory <ga...@gmail.com>
> wrote:
>
> > Some sample pack200 files should also be part of tests.
> >
> > Gary
> >
> > On Thu, Oct 28, 2021, 10:16 Gary Gregory <ga...@gmail.com> wrote:
> >
> > > You'll have to figure out the implementation details but I will be
> happy
> > > to review PRs on GitHub.
> > >
> > > Gary
> > >
> > > On Thu, Oct 28, 2021, 08:32 Eric Bresie <eb...@gmail.com> wrote:
> > >
> > >> In this particular case, there were packed modules which had major /
> > minor
> > >> versions not equal to the Major version 7 or minor version 150
> supported
> > >> in
> > >> the code.
> > >>
> > >> This results in the exception, preventing it from unpacking. The need
> > is
> > >> to be able to unpack an older packed file.
> > >>
> > >> As I understand it, some of this has to do with each version may
> handle
> > >> things a bit differently which may result in limited compatibility.
> Not
> > >> sure if it’s keys on byte code level details or compression algorithms
> > in
> > >> use or what.
> > >>
> > >> How would the code need to be modified to support this?
> > >>
> > >> Eric
> > >>
> > >> On Tue, Oct 26, 2021 at 1:12 PM Gary Gregory <ga...@gmail.com>
> > >> wrote:
> > >>
> > >> > There is not. The intent of the current code is simply to provide
> > >> > functionality that was dropped from the JRE.
> > >> >
> > >> > What newer versions and how are they different?
> > >> >
> > >> > Gary
> > >> >
> > >> >
> > >> > On Tue, Oct 26, 2021, 13:49 Eric Bresie <eb...@gmail.com> wrote:
> > >> >
> > >> > > While trying to unpack an older generated pack file, it was noted
> > that
> > >> > > Pack200Exceptions were getting raised due to the Major/Minor
> Version
> > >> in
> > >> > > used which seems to be I this area.
> > >> > >
> > >> > >
> > >> > >
> > >> >
> > >>
> >
> https://github.com/apache/commons-compress/blob/master/src/main/java/org/apache/commons/compress/harmony/unpack200/SegmentHeader.java#L131-L155
> > >> > >
> > >> > > Is there an work to support newer versions?
> > >> > >
> > >> > > Eric Bresie
> > >> > > Ebresie@gmail.com
> > >> >
> > >> --
> > >> Eric Bresie
> > >> ebresie@gmail.com
> > >>
> > >
> >
> --
> Eric Bresie
> ebresie@gmail.com
>
Re: [Compress] Pack200Exceptions on Old packed files
Posted by Eric Bresie <eb...@gmail.com>.
Where in the current implementation might one look for these sorts of
things?
In the quoted code seems to focus on the SegmentHeader related details
would something around this be needed?
I see some of the major/minor may be based on read code and relate to the
Codec in use.
While looking for SegmentHeader code read code which keys on different
possible codec. For newer iterations has the codec changed would some new
codec need to be added? Since this was an older package I wouldn’t have
thought so.
I find the following which maybe would be helpful but not sure yet.
https://docs.oracle.com/javase/7/docs/technotes/guides/pack200/pack-spec.html
Eric Bresie
ebresie@gmail.com
On Sun, Oct 31, 2021 at 4:44 PM Gary Gregory <ga...@gmail.com> wrote:
> Some sample pack200 files should also be part of tests.
>
> Gary
>
> On Thu, Oct 28, 2021, 10:16 Gary Gregory <ga...@gmail.com> wrote:
>
> > You'll have to figure out the implementation details but I will be happy
> > to review PRs on GitHub.
> >
> > Gary
> >
> > On Thu, Oct 28, 2021, 08:32 Eric Bresie <eb...@gmail.com> wrote:
> >
> >> In this particular case, there were packed modules which had major /
> minor
> >> versions not equal to the Major version 7 or minor version 150 supported
> >> in
> >> the code.
> >>
> >> This results in the exception, preventing it from unpacking. The need
> is
> >> to be able to unpack an older packed file.
> >>
> >> As I understand it, some of this has to do with each version may handle
> >> things a bit differently which may result in limited compatibility. Not
> >> sure if it’s keys on byte code level details or compression algorithms
> in
> >> use or what.
> >>
> >> How would the code need to be modified to support this?
> >>
> >> Eric
> >>
> >> On Tue, Oct 26, 2021 at 1:12 PM Gary Gregory <ga...@gmail.com>
> >> wrote:
> >>
> >> > There is not. The intent of the current code is simply to provide
> >> > functionality that was dropped from the JRE.
> >> >
> >> > What newer versions and how are they different?
> >> >
> >> > Gary
> >> >
> >> >
> >> > On Tue, Oct 26, 2021, 13:49 Eric Bresie <eb...@gmail.com> wrote:
> >> >
> >> > > While trying to unpack an older generated pack file, it was noted
> that
> >> > > Pack200Exceptions were getting raised due to the Major/Minor Version
> >> in
> >> > > used which seems to be I this area.
> >> > >
> >> > >
> >> > >
> >> >
> >>
> https://github.com/apache/commons-compress/blob/master/src/main/java/org/apache/commons/compress/harmony/unpack200/SegmentHeader.java#L131-L155
> >> > >
> >> > > Is there an work to support newer versions?
> >> > >
> >> > > Eric Bresie
> >> > > Ebresie@gmail.com
> >> >
> >> --
> >> Eric Bresie
> >> ebresie@gmail.com
> >>
> >
>
--
Eric Bresie
ebresie@gmail.com
Re: [Compress] Pack200Exceptions on Old packed files
Posted by Gary Gregory <ga...@gmail.com>.
Some sample pack200 files should also be part of tests.
Gary
On Thu, Oct 28, 2021, 10:16 Gary Gregory <ga...@gmail.com> wrote:
> You'll have to figure out the implementation details but I will be happy
> to review PRs on GitHub.
>
> Gary
>
> On Thu, Oct 28, 2021, 08:32 Eric Bresie <eb...@gmail.com> wrote:
>
>> In this particular case, there were packed modules which had major / minor
>> versions not equal to the Major version 7 or minor version 150 supported
>> in
>> the code.
>>
>> This results in the exception, preventing it from unpacking. The need is
>> to be able to unpack an older packed file.
>>
>> As I understand it, some of this has to do with each version may handle
>> things a bit differently which may result in limited compatibility. Not
>> sure if it’s keys on byte code level details or compression algorithms in
>> use or what.
>>
>> How would the code need to be modified to support this?
>>
>> Eric
>>
>> On Tue, Oct 26, 2021 at 1:12 PM Gary Gregory <ga...@gmail.com>
>> wrote:
>>
>> > There is not. The intent of the current code is simply to provide
>> > functionality that was dropped from the JRE.
>> >
>> > What newer versions and how are they different?
>> >
>> > Gary
>> >
>> >
>> > On Tue, Oct 26, 2021, 13:49 Eric Bresie <eb...@gmail.com> wrote:
>> >
>> > > While trying to unpack an older generated pack file, it was noted that
>> > > Pack200Exceptions were getting raised due to the Major/Minor Version
>> in
>> > > used which seems to be I this area.
>> > >
>> > >
>> > >
>> >
>> https://github.com/apache/commons-compress/blob/master/src/main/java/org/apache/commons/compress/harmony/unpack200/SegmentHeader.java#L131-L155
>> > >
>> > > Is there an work to support newer versions?
>> > >
>> > > Eric Bresie
>> > > Ebresie@gmail.com
>> >
>> --
>> Eric Bresie
>> ebresie@gmail.com
>>
>
Re: [Compress] Pack200Exceptions on Old packed files
Posted by Gary Gregory <ga...@gmail.com>.
You'll have to figure out the implementation details but I will be happy to
review PRs on GitHub.
Gary
On Thu, Oct 28, 2021, 08:32 Eric Bresie <eb...@gmail.com> wrote:
> In this particular case, there were packed modules which had major / minor
> versions not equal to the Major version 7 or minor version 150 supported in
> the code.
>
> This results in the exception, preventing it from unpacking. The need is
> to be able to unpack an older packed file.
>
> As I understand it, some of this has to do with each version may handle
> things a bit differently which may result in limited compatibility. Not
> sure if it’s keys on byte code level details or compression algorithms in
> use or what.
>
> How would the code need to be modified to support this?
>
> Eric
>
> On Tue, Oct 26, 2021 at 1:12 PM Gary Gregory <ga...@gmail.com>
> wrote:
>
> > There is not. The intent of the current code is simply to provide
> > functionality that was dropped from the JRE.
> >
> > What newer versions and how are they different?
> >
> > Gary
> >
> >
> > On Tue, Oct 26, 2021, 13:49 Eric Bresie <eb...@gmail.com> wrote:
> >
> > > While trying to unpack an older generated pack file, it was noted that
> > > Pack200Exceptions were getting raised due to the Major/Minor Version in
> > > used which seems to be I this area.
> > >
> > >
> > >
> >
> https://github.com/apache/commons-compress/blob/master/src/main/java/org/apache/commons/compress/harmony/unpack200/SegmentHeader.java#L131-L155
> > >
> > > Is there an work to support newer versions?
> > >
> > > Eric Bresie
> > > Ebresie@gmail.com
> >
> --
> Eric Bresie
> ebresie@gmail.com
>
Re: [Compress] Pack200Exceptions on Old packed files
Posted by Eric Bresie <eb...@gmail.com>.
In this particular case, there were packed modules which had major / minor
versions not equal to the Major version 7 or minor version 150 supported in
the code.
This results in the exception, preventing it from unpacking. The need is
to be able to unpack an older packed file.
As I understand it, some of this has to do with each version may handle
things a bit differently which may result in limited compatibility. Not
sure if it’s keys on byte code level details or compression algorithms in
use or what.
How would the code need to be modified to support this?
Eric
On Tue, Oct 26, 2021 at 1:12 PM Gary Gregory <ga...@gmail.com> wrote:
> There is not. The intent of the current code is simply to provide
> functionality that was dropped from the JRE.
>
> What newer versions and how are they different?
>
> Gary
>
>
> On Tue, Oct 26, 2021, 13:49 Eric Bresie <eb...@gmail.com> wrote:
>
> > While trying to unpack an older generated pack file, it was noted that
> > Pack200Exceptions were getting raised due to the Major/Minor Version in
> > used which seems to be I this area.
> >
> >
> >
> https://github.com/apache/commons-compress/blob/master/src/main/java/org/apache/commons/compress/harmony/unpack200/SegmentHeader.java#L131-L155
> >
> > Is there an work to support newer versions?
> >
> > Eric Bresie
> > Ebresie@gmail.com
>
--
Eric Bresie
ebresie@gmail.com
Re: [Compress] Pack200Exceptions on Old packed files
Posted by Gary Gregory <ga...@gmail.com>.
There is not. The intent of the current code is simply to provide
functionality that was dropped from the JRE.
What newer versions and how are they different?
Gary
On Tue, Oct 26, 2021, 13:49 Eric Bresie <eb...@gmail.com> wrote:
> While trying to unpack an older generated pack file, it was noted that
> Pack200Exceptions were getting raised due to the Major/Minor Version in
> used which seems to be I this area.
>
>
> https://github.com/apache/commons-compress/blob/master/src/main/java/org/apache/commons/compress/harmony/unpack200/SegmentHeader.java#L131-L155
>
> Is there an work to support newer versions?
>
> Eric Bresie
> Ebresie@gmail.com