[GitHub] merlimat commented on issue #1108: Replace DoubleByteBuf with CompositeByteBuf because of perf regression with Netty > 4.1.12

[GitBox <gi...@apache.org>]

merlimat commented on issue #1108: Replace DoubleByteBuf with CompositeByteBuf because of perf regression with Netty > 4.1.12
URL: https://github.com/apache/bookkeeper/pull/1108#issuecomment-362434292
 
 
   > @merlimat have you considered pushing the modified compositebytebuf back to netty? 
   
   Right now, in Pulsar I have changed it to `ByteBufPair` which is very simple in that it's just a holder of 2 buffers, without trying to mimic the buffer interface. 
   https://github.com/apache/incubator-pulsar/blob/40d37b10731707724b28f11254c4a72697f57bee/pulsar-common/src/main/java/org/apache/pulsar/common/api/ByteBufPair.java
   
   For BK, it's a bit more involved because we have 3 buffers in some places. I have a WIP at https://github.com/merlimat/bookkeeper/commit/c7d2b2ef6bafba32d8697edd673475e3376360e9 though it requires a bit more testing
   
   If the `ByteBufPair` and/or `ByteBufList` are generally useful, I surely will submit to Netty.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services